You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "gaoran10 (via GitHub)" <gi...@apache.org> on 2023/06/19 09:21:51 UTC
[GitHub] [pulsar] gaoran10 opened a new pull request, #20605: [fix][sql] Remove useless configuration for Pulsar SQL
gaoran10 opened a new pull request, #20605:
URL: https://github.com/apache/pulsar/pull/20605
### Motivation
In PR https://github.com/apache/pulsar/pull/14506, we remove the useless config `managedLedgerNumWorkerThreads`
but we didn't remove the config from the config file, if users use this configuration, the Pulsar SQL can't startup due to `strictConfig` mode, remove this useless configuration for Pulsar SQL.
```
// at this point all config file properties should be used
// so we can calculate the unused properties
unusedProperties.keySet().removeAll(configurationFactory.getUsedProperties());
for (String key : unusedProperties.keySet()) {
Message message = new Message(format("Configuration property '%s' was not used", key));
(strictConfig ? errors : warnings).add(message);
}
// If there are configuration errors, fail-fast to keep output clean
if (!errors.isEmpty()) {
throw new ApplicationConfigurationException(errors, warnings);
}
```
### Modifications
Remove useless configuration `pulsar.managed-ledger-num-worker-threads` from the config file.
### Verifying this change
Add tests for the annotated configurations.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #20605: [fix][sql] Remove useless configuration for Pulsar SQL
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #20605: [fix][sql] Remove useless configuration for Pulsar SQL
URL: https://github.com/apache/pulsar/pull/20605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #20605: [fix][sql] Remove useless configuration for Pulsar SQL
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #20605:
URL: https://github.com/apache/pulsar/pull/20605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20605: [fix][sql] Remove useless configuration for Pulsar SQL
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20605:
URL: https://github.com/apache/pulsar/pull/20605#issuecomment-1600732271
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20605](https://app.codecov.io/gh/apache/pulsar/pull/20605?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d5b172f) into [master](https://app.codecov.io/gh/apache/pulsar/commit/8125d1f6f63014a2aba1b53d48e98b9546afd001?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8125d1f) will **increase** coverage by `0.80%`.
> The diff coverage is `n/a`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20605?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20605 +/- ##
============================================
+ Coverage 72.29% 73.09% +0.80%
- Complexity 31951 32032 +81
============================================
Files 1854 1867 +13
Lines 138462 138670 +208
Branches 15221 15238 +17
============================================
+ Hits 100095 101367 +1272
+ Misses 30384 29275 -1109
- Partials 7983 8028 +45
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.20% <ø> (?)` | |
| systests | `24.98% <ø> (?)` | |
| unittests | `72.39% <ø> (+0.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 205 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20605/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #20605: [fix][sql] Remove useless configuration for Pulsar SQL
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #20605: [fix][sql] Remove useless configuration for Pulsar SQL
URL: https://github.com/apache/pulsar/pull/20605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org