[jira] [Commented] (SPARK-30858) IntegralDivide's dataType should not depend on SQLConf.get

["Maxim Gekk (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-30858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039410#comment-17039410 ] 

Maxim Gekk commented on SPARK-30858:
------------------------------------

> This is a problem because the configuration can change between different phases of planning

[~hvanhovell] Is the code below right solution for the problem?
{code:scala}
case class IntegralDivide(
  left: Expression,
  right: Expression,
  integralDivideReturnLong: Boolean) extends DivModLike {

  def this(left: Expression, right: Expression) = {
    this(left, right, SQLConf.get.integralDivideReturnLong)
  }

  override def dataType: DataType = if (integralDivideReturnLong) {
    LongType
  } else {
    left.dataType
  }
{code}

> IntegralDivide's dataType should not depend on SQLConf.get
> ----------------------------------------------------------
>
>                 Key: SPARK-30858
>                 URL: https://issues.apache.org/jira/browse/SPARK-30858
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 3.0.0
>            Reporter: Herman van Hövell
>            Priority: Blocker
>
> {{IntegralDivide}}'s dataType depends on the value of {{SQLConf.get.integralDivideReturnLong}}. This is a problem because the configuration can change between different phases of planning, and this can silently break a query plan which can lead to crashes or data corruption. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org