You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by ericcarlschwartz <gi...@git.apache.org> on 2015/11/14 22:34:00 UTC
[GitHub] trafficserver pull request: [TS-4024] wire tracing enhancements
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/337
[TS-4024] wire tracing enhancements
This is a combo of three things:
1) Change I made to make wire tracing dynamically available.
2) A change from Susan to give better SSL_Error messages in wire traces.
3) A change in HttpSM so wire_tracing doesn't have undefined behavior with PluginVCs. Also generally cleaned up the syntax there
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ericcarlschwartz/trafficserver ts-4024
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/337.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #337
----
commit 8a791eca8418fb99e482be26af12b43d29853474
Author: ericcarlschwartz <es...@gmail.com>
Date: 2015-11-14T21:26:58Z
[TS-4024] wire tracing enhancements
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4024] wire tracing enhancements
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/337#issuecomment-160669428
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4024] wire tracing enhancements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/337
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4024] wire tracing enhancements
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/337#issuecomment-160731514
Seems reasonable, except we should look at unifying the SSL error reporting logic - that looks very cut and pasted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---