[GitHub] vanzin commented on a change in pull request #23790: [SPARK-26792][CORE] Apply custom log URL to Spark UI

[GitBox <gi...@apache.org>]

vanzin commented on a change in pull request #23790: [SPARK-26792][CORE] Apply custom log URL to Spark UI
URL: https://github.com/apache/spark/pull/23790#discussion_r260905275
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/scheduler/CoarseGrainedSchedulerBackendSuite.scala
 ##########
 @@ -129,4 +181,34 @@ class CoarseGrainedSchedulerBackendSuite extends SparkFunSuite with LocalSparkCo
       { return }
     )
   }
+
+  private def getCustomExecutorLogUrl(includeFileName: Boolean): String = {
 
 Review comment:
   This is only called once; could be inlined.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org