[GitHub] [ozone] xiaoyuyao commented on a change in pull request #1604: HDDS-4356. SCM is flooded with useless "Deleting blocks" messages.

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #1604:
URL: https://github.com/apache/ozone/pull/1604#discussion_r534310951



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java
##########
@@ -129,9 +129,12 @@ public void incrementCount(List<Long> txIDs) throws IOException {
         DeletedBlocksTransaction block =
             scmMetadataStore.getDeletedBlocksTXTable().get(txID);
         if (block == null) {
-          // Should we make this an error ? How can we not find the deleted
-          // TXID?
-          LOG.warn("Deleted TXID {} not found.", txID);

Review comment:
       Agree with the analysis. Let's investigate the cause in a separate JIRA. +1 for merging the PR as-is. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org