You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by ja...@apache.org on 2024/10/30 12:09:14 UTC

(mynewt-core) branch master updated (e805fc039 -> f8607397b)

This is an automated email from the ASF dual-hosted git repository.

janc pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


    from e805fc039 baselibc: Don't use -umain for native build
     new cff00d23f ci: Enable newt test on Mac
     new 519ce54dd encoding/json: Use unsigned type for bitfield
     new f8607397b util/cbmem: Fix test case 3 compilation

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .github/workflows/newt_test_all.yml                   | 9 +++++++--
 encoding/json/include/json/json.h                     | 2 +-
 util/cbmem/selftest/src/testcases/cbmem_test_case_3.c | 3 ---
 3 files changed, 8 insertions(+), 6 deletions(-)


(mynewt-core) 03/03: util/cbmem: Fix test case 3 compilation

Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

janc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git

commit f8607397b3abb833760d68be89fd2db2b8a54b7c
Author: Szymon Janc <sz...@codecoup.pl>
AuthorDate: Wed Oct 30 11:55:30 2024 +0100

    util/cbmem: Fix test case 3 compilation
    
    Removed unused variable
    
    repos/apache-mynewt-core/util/cbmem/selftest/src/testcases/
        cbmem_test_case_3.c:29:9: error: variable 'i' set but not
        used [-Werror,-Wunused-but-set-variable]
    4941
        int i;
    4942
            ^
    4943
    1 error generated.
---
 util/cbmem/selftest/src/testcases/cbmem_test_case_3.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/util/cbmem/selftest/src/testcases/cbmem_test_case_3.c b/util/cbmem/selftest/src/testcases/cbmem_test_case_3.c
index 040e62ddf..a5e4cf9f3 100644
--- a/util/cbmem/selftest/src/testcases/cbmem_test_case_3.c
+++ b/util/cbmem/selftest/src/testcases/cbmem_test_case_3.c
@@ -26,10 +26,8 @@ TEST_CASE_SELF(cbmem_test_case_3)
     uint16_t off;
     uint16_t len;
     uint8_t buf[128];
-    int i;
     int rc;
 
-    i = 0;
     cbmem_iter_start(&cbmem1, &iter);
     while (1) {
         hdr = cbmem_iter_next(&cbmem1, &iter);
@@ -54,7 +52,6 @@ TEST_CASE_SELF(cbmem_test_case_3)
         TEST_ASSERT_FATAL(len == CBMEM1_ENTRY_SIZE,
                 "Couldn't read full entry, expected %d got %d",
                 CBMEM1_ENTRY_SIZE, len);
-        i++;
 
         /* go apesh*t, and read data out of bounds, see what we get. */
         rc = cbmem_read(&cbmem1, hdr, buf, CBMEM1_ENTRY_SIZE * 2, sizeof(buf));


(mynewt-core) 02/03: encoding/json: Use unsigned type for bitfield

Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

janc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git

commit 519ce54dd492eb4b0f789a7a9dc7e8131f13cf88
Author: Szymon Janc <sz...@codecoup.pl>
AuthorDate: Wed Oct 30 11:49:24 2024 +0100

    encoding/json: Use unsigned type for bitfield
    
    Enabling -Wsingle-bit-bitfield-constant-conversion compains.
    repos/apache-mynewt-core/encoding/json/src/json_encode.c:187:27: error:
        implicit truncation from 'int' to a one-bit wide bit-field changes
        value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
    562
        encoder->je_wr_commas = 1;
    563
                              ^ ~
    564
    repos/apache-mynewt-core/encoding/json/src/json_encode.c:199:27: error:
        implicit truncation from 'int' to a one-bit wide bit-field changes
        value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
    565
        encoder->je_wr_commas = 1;
    566
                              ^ ~
    567
    repos/apache-mynewt-core/encoding/json/src/json_encode.c:233:27: error:
        implicit truncation from 'int' to a one-bit wide bit-field changes
        value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
    568
        encoder->je_wr_commas = 1;
    569
                              ^ ~
    570
    repos/apache-mynewt-core/encoding/json/src/json_encode.c:244:27: error:
        implicit truncation from 'int' to a one-bit wide bit-field changes
        value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
    571
        encoder->je_wr_commas = 1;
    572
                              ^ ~
---
 encoding/json/include/json/json.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/encoding/json/include/json/json.h b/encoding/json/include/json/json.h
index f6a4d0609..93de54c8d 100644
--- a/encoding/json/include/json/json.h
+++ b/encoding/json/include/json/json.h
@@ -83,7 +83,7 @@ typedef int (*json_write_func_t)(void *buf, char *data,
 struct json_encoder {
     json_write_func_t je_write;
     void *je_arg;
-    int je_wr_commas:1;
+    unsigned int je_wr_commas : 1;
     char je_encode_buf[64];
 };
 


(mynewt-core) 01/03: ci: Enable newt test on Mac

Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

janc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git

commit cff00d23fbdf8ddcbacaac18b65a720732513669
Author: Szymon Janc <sz...@codecoup.pl>
AuthorDate: Wed Oct 30 10:19:17 2024 +0100

    ci: Enable newt test on Mac
    
    We properly support 64bit in native target now so those can be
    re-enabled.
---
 .github/workflows/newt_test_all.yml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/newt_test_all.yml b/.github/workflows/newt_test_all.yml
index e51766427..8bbbfcedb 100644
--- a/.github/workflows/newt_test_all.yml
+++ b/.github/workflows/newt_test_all.yml
@@ -24,18 +24,23 @@ on: [push, pull_request]
 jobs:
   newt_test:
     name: Run newt test all
-    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, macos-13]
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
           go-version: 'stable'
       - name: Install Dependencies
+        if: matrix.os == 'ubuntu-latest'
         run: |
              sudo apt-get update
              sudo apt-get install -y gcc-multilib
       - name: Install GNU sed
-        if: matrix.os == 'macos-latest'
+        if: matrix.os == 'macos-13'
         run: |
              brew install gnu-sed
              echo "$(brew --prefix)/opt/gnu-sed/libexec/gnubin" >> $GITHUB_PATH