You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@myfaces.apache.org by Mathias Walter <ma...@gmx.net> on 2008/07/02 19:36:05 UTC

[Trinidad] nested tr:panelFormLayout

Hi,

I'd like to have the following component structure:

<tr:table>
   <f:facet name="detailStamp">
      <tr:panelFormLayout>
         some <tr:inputText>
         <tr:table>
            <f:facet name="detailStamp">
               <tr:panelFormLayout>
                  some <tr:inputText>
               </tr:panelFormLayout>
            </f:facet>
         </tr:table>
      </tr:panelFormLayout>
   </f:facet>
</tr:table>

Unfortunately, the innermost tr:panelFormLayout does not align the
inputTexts like the outermost tr:panelFormLayout. The input element will be
placed below the label. That's not what I want and what's expected.

According to the documentation: If this panelFormLayout is inside of another
panelFormLayout, maxColumns will always be 1.
But that sould not affect a nondirect nested panelFormLayout. And
maxColumns=1 does not mean that label and input will be aligned one upon the
other.

How can I achive a correct panelFormLayout for the innermost components?

BTW: I'm using Trinidad 1.2.8 with Facelets 1.1.14.

--
Kind regards,
Mathias


Re: Trinidad Release notes

Posted by Matthias Wessendorf <ma...@apache.org>.
Hi,

I think we forgot to maintain that page :-)
The reason is, that we point to the release notes from the download section:
http://myfaces.apache.org/trinidad/download.html

The release notes are also available via the main myfaces page:
http://myfaces.apache.org/

-M

On Mon, Jul 7, 2008 at 12:11 PM,  <wo...@pta.de> wrote:
>
> Hi,
>
> when I click on the link to the release notes of Trinidad
>
> http://myfaces.apache.org/trinidad/release-notes.html
>
> all I get is a release notes document for Version 1.0.3. Thus I was
> wondering whether or not it would make sense to date
> this up and have release notes for each version so one can see at a glance
> what the major highlights of the rsp. version is :-)
>
> I would not mind dating up this release information myself but then I would
> need to know how to find(reconstruct?) it ..;)
>
> Best wishes,
> Wolfgang.



-- 
Matthias Wessendorf

further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org

Trinidad Release notes

Posted by wo...@pta.de.
Hi,

when I click on the link to the release notes of Trinidad

http://myfaces.apache.org/trinidad/release-notes.html

all I get is a release notes document for Version 1.0.3. Thus I was 
wondering whether or not it would make sense to date
this up and have release notes for each version so one can see at a glance 
what the major highlights of the rsp. version is :-)

I would not mind dating up this release information myself but then I 
would need to know how to find(reconstruct?) it ..;)

Best wishes,
Wolfgang.

RE: [Trinidad] 1.2.9-core

Posted by Mathias Walter <ma...@gmx.net>.
Hi Matthias,

> > Up to 1.2.8, all works fine. I checked the fixes for 1.2.9, 
> but could not
> > find a related one.
> 
> hrm, that means, by just changing from 1.2.8 to 1.2.9 shows up,
> and goes away, when going back to 128?

Exactly.

> 
> strange.
> I know there was a change in the EL engine, that is used by glassfish
> or jetty, but
> I am not aware of a change in Trinidad in that direction.

I do not use Glassfisch.

I'm using Trinidad with JBoss Seam (2.0.2.SP1). There is a jboss-el.jar and
a commons-el-1.0.jar, which are required to run Seam. I did not change these
files after upgrading to Trinidad 1.2.9.
I can try to setup a project without Seam and check if it's depending on the
other EL jars or just on the new Trinidad release.
But it's obvious that Trinidad is involved, because it works with 1.2.8 and
breaks with 1.2.9.

Unfortunately, I'm very bussy the next 10 days and can not spend much time
to investigate the problem.

> thanks for the code snippets.
> Since I am almost on vacation, do you mind to file a bug?
> So, that we don't forget about it?

Sure: https://issues.apache.org/jira/browse/TRINIDAD-1144

--
Regards,
Mathias


Re: [Trinidad] 1.2.9-core

Posted by Matthias Wessendorf <ma...@apache.org>.
Hi,

On Fri, Jul 4, 2008 at 8:27 PM, Mathias Walter <ma...@gmx.net> wrote:
> Hi,
>
> just to let you know: The nightly build of Trinidad 1.2.9 breaks some EL
> getter or setter methods. It's hard to explain.

thanks for the heads-up.

>
> I'm using a facelet component which sets a variable to the row of a tr:table
> (<c:set var="entity" value="#{row}" />). This variable is then used in a
> child table (which is also a facelet component) as source value.
> In 1.2.9 this approach does not work anymore. The entity is set to the
> current row of the child table and does not contain the row entity set
> before.
>
> Up to 1.2.8, all works fine. I checked the fixes for 1.2.9, but could not
> find a related one.

hrm, that means, by just changing from 1.2.8 to 1.2.9 shows up,
and goes away, when going back to 128?

strange.
I know there was a change in the EL engine, that is used by glassfish
or jetty, but
I am not aware of a change in Trinidad in that direction.

>
> facelet tag code:
>
> <ui:composition>
>        <c:choose>
>                <c:when test="${empty value}">
>                    <c:set var="source" value="${backingBean.list}" />
>                </c:when>
>                <c:otherwise>
>                    <c:set var="source" value="${entity[value]}" />
>                </c:otherwise>
>        </c:choose>
>        <c:choose>
>                <c:when test="${empty eventBinding}">
>                    <c:set var="binding" value="${backingBean}" />
>                </c:when>
>                <c:otherwise>
>                    <c:set var="binding" value="${eventBinding}" />
>                </c:otherwise>
>        </c:choose>
>        <tr:table value="${source}" binding="${binding.model}" var="row">
>                <c:set var="entity" value="#{row}" />
>                <ui:insert />
>                <tr:column headerText="Actions">
>                        <tr:panelButtonBar>
>                                <tr:commandLink action="#{backingBean.edit}"
> text="Edit" partialSubmit="true" rendered="#{!backingBean.editMode and
> backingBean.visibleOnly}" immediate="true" />
>                                <tr:commandLink action="#{backingBean.save}"
> text="Save" partialSubmit="true" rendered="#{!backingBean.visibleOnly}" />
>                                <tr:commandLink
> action="#{backingBean.cancel}" text="Cancel" partialSubmit="true"
> rendered="#{!backingBean.visibleOnly}" immediate="true">
>                                        <tr:resetActionListener/>
>                                </tr:commandLink>
>                        </tr:panelButtonBar>
>                </tr:column>
>        </tr:table>
> </ui:composition>
>
> xhtml code:
>
> <i:ietable panelCaption="Samples" backingBean="#{samples}"
> eventBinding="#{samplesBindings}">
>        <i:field label="ID" name="id" columns="6" readOnly="true"/>
>        <f:facet name="detailStamp">
>                <i:ietable panelCaption="Findings" value="findings"
> backingBean="#{findings}" eventBinding="#{findingsBindings}" parent="#{row}"
> nested="true">

thanks for the code snippets.
Since I am almost on vacation, do you mind to file a bug?
So, that we don't forget about it?
I already thought about a 1.2.9 for end of July, since some bugs where fixed,
but if this is really in Trinidad, IMO this is a bad bug.

-M


>
> --
> Regards,
> Mathias
>
>
>



-- 
Matthias Wessendorf

further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org

[Trinidad] 1.2.9-core

Posted by Mathias Walter <ma...@gmx.net>.
Hi,

just to let you know: The nightly build of Trinidad 1.2.9 breaks some EL
getter or setter methods. It's hard to explain.

I'm using a facelet component which sets a variable to the row of a tr:table
(<c:set var="entity" value="#{row}" />). This variable is then used in a
child table (which is also a facelet component) as source value.
In 1.2.9 this approach does not work anymore. The entity is set to the
current row of the child table and does not contain the row entity set
before.

Up to 1.2.8, all works fine. I checked the fixes for 1.2.9, but could not
find a related one.

facelet tag code:

<ui:composition>
	<c:choose>
		<c:when test="${empty value}">
		    <c:set var="source" value="${backingBean.list}" />
		</c:when>
		<c:otherwise>
		    <c:set var="source" value="${entity[value]}" />
		</c:otherwise>
	</c:choose>
	<c:choose>
		<c:when test="${empty eventBinding}">
		    <c:set var="binding" value="${backingBean}" />
		</c:when>
		<c:otherwise>
		    <c:set var="binding" value="${eventBinding}" />
		</c:otherwise>
	</c:choose>
	<tr:table value="${source}" binding="${binding.model}" var="row">
		<c:set var="entity" value="#{row}" />
		<ui:insert />
		<tr:column headerText="Actions">
			<tr:panelButtonBar>
				<tr:commandLink action="#{backingBean.edit}"
text="Edit" partialSubmit="true" rendered="#{!backingBean.editMode and
backingBean.visibleOnly}" immediate="true" />
				<tr:commandLink action="#{backingBean.save}"
text="Save" partialSubmit="true" rendered="#{!backingBean.visibleOnly}" />
				<tr:commandLink
action="#{backingBean.cancel}" text="Cancel" partialSubmit="true"
rendered="#{!backingBean.visibleOnly}" immediate="true">
					<tr:resetActionListener/>
				</tr:commandLink>
			</tr:panelButtonBar>
		</tr:column>
	</tr:table>
</ui:composition>

xhtml code:

<i:ietable panelCaption="Samples" backingBean="#{samples}"
eventBinding="#{samplesBindings}">
	<i:field label="ID" name="id" columns="6" readOnly="true"/>
	<f:facet name="detailStamp">
		<i:ietable panelCaption="Findings" value="findings"
backingBean="#{findings}" eventBinding="#{findingsBindings}" parent="#{row}"
nested="true">

--
Regards,
Mathias
	


RE: [Trinidad] nested tr:panelFormLayout

Posted by Mathias Walter <ma...@gmx.net>.
Hi,

just for your information. I solved it for me by just using
<trh:tableLayout> instead of the innermost <tr:panelFormLayout>. The labels,
messages and inputs will be lined up correctly.

--
Regards,
Mathias

> -----Original Message-----
> From: Mathias Walter [mailto:mathias.walter@gmx.net] 
> Sent: Wednesday, July 02, 2008 7:36 PM
> To: 'MyFaces Discussion'
> Subject: [Trinidad] nested tr:panelFormLayout
> 
> 
> Hi,
> 
> I'd like to have the following component structure:
> 
> <tr:table>
>    <f:facet name="detailStamp">
>       <tr:panelFormLayout>
>          some <tr:inputText>
>          <tr:table>
>             <f:facet name="detailStamp">
>                <tr:panelFormLayout>
>                   some <tr:inputText>
>                </tr:panelFormLayout>
>             </f:facet>
>          </tr:table>
>       </tr:panelFormLayout>
>    </f:facet>
> </tr:table>
> 
> Unfortunately, the innermost tr:panelFormLayout does not align the
> inputTexts like the outermost tr:panelFormLayout. The input 
> element will be
> placed below the label. That's not what I want and what's expected.
> 
> According to the documentation: If this panelFormLayout is 
> inside of another
> panelFormLayout, maxColumns will always be 1.
> But that sould not affect a nondirect nested panelFormLayout. And
> maxColumns=1 does not mean that label and input will be 
> aligned one upon the
> other.
> 
> How can I achive a correct panelFormLayout for the innermost 
> components?
> 
> BTW: I'm using Trinidad 1.2.8 with Facelets 1.1.14.
> 
> --
> Kind regards,
> Mathias


RE: [Trinidad] tr:selectBooleanCheckbox height

Posted by "Perkins, Nate-P63196" <Na...@gdc4s.com>.
It seems like a bug to me (though I never got around to a JIRA ticket
for it).  I can't imagine why this behavior would be considered correct.


Nate Perkins
General Dynamics C4 Systems

>This email message is for the sole use of the intended recipient(s) and
may contain GDC4S
> confidential or privileged information. Any unauthorized review, use,
disclosure or distribution
> is prohibited. If you are not an intended recipient, please contact
the sender by reply email and
> destroy all copies of the original message.
>

-----Original Message-----
From: Mathias Walter [mailto:mathias.walter@gmx.net] 
Sent: Wednesday, July 02, 2008 1:24 PM
To: 'MyFaces Discussion'
Subject: RE: [Trinidad] tr:selectBooleanCheckbox height

Hi Nate,

> We solved this by adding this to our skin:
> 
> .OraInlineErrorText {
> margin-left: 0px! important
> }

That works great! Many thanks.

Shall I create an JIRA issue?

--
Kind regards,
Mathias

> 
> 
> Nate Perkins
> General Dynamics C4 Systems
> 
> -----Original Message-----
> From: Mathias Walter [mailto:mathias.walter@gmx.net]
> Sent: Wednesday, July 02, 2008 11:16 AM
> To: 'MyFaces Discussion'
> Subject: RE: [Trinidad] tr:selectBooleanCheckbox height
> 
> Hi,
> 
> I forgot to mention the environment: FireFox 2 and 3. The row height 
> increase does not occur with IE6.
> 
> --
> Kind regards,
> Mathias
> 
> > -----Original Message-----
> > From: Mathias Walter [mailto:mathias.walter@gmx.net]
> > Sent: Wednesday, July 02, 2008 8:12 PM
> > To: 'MyFaces Discussion'
> > Subject: [Trinidad] tr:selectBooleanCheckbox height
> > 
> > 
> > Hi,
> > 
> > I've observed that the message element for a
> tr:selectBooleanCheckbox
> > will be rendered in a table as
> > 
> > <span style="margin-left: 21px;" class="OraInlineErrorText"/>
> > 
> > whereas for all other components it will be rendered as
> > 
> > <span class="OraInlineErrorText"/>.
> > 
> > The additional style attribute causes the span to be visible and 
> > increases the row height, even if no error message will be
> displayed.
> > 
> > How can I suppress this increase in row height?
> > 
> > --
> > Kind regards,
> > Mathias


RE: [Trinidad] tr:selectBooleanCheckbox height

Posted by Mathias Walter <ma...@gmx.net>.
Hi Nate,

> We solved this by adding this to our skin:
> 
> .OraInlineErrorText {
> margin-left: 0px! important
> } 

That works great! Many thanks.

Shall I create an JIRA issue?

--
Kind regards,
Mathias

> 
> 
> Nate Perkins
> General Dynamics C4 Systems
> 
> -----Original Message-----
> From: Mathias Walter [mailto:mathias.walter@gmx.net] 
> Sent: Wednesday, July 02, 2008 11:16 AM
> To: 'MyFaces Discussion'
> Subject: RE: [Trinidad] tr:selectBooleanCheckbox height
> 
> Hi,
> 
> I forgot to mention the environment: FireFox 2 and 3. The row height
> increase does not occur with IE6.
> 
> --
> Kind regards,
> Mathias
> 
> > -----Original Message-----
> > From: Mathias Walter [mailto:mathias.walter@gmx.net]
> > Sent: Wednesday, July 02, 2008 8:12 PM
> > To: 'MyFaces Discussion'
> > Subject: [Trinidad] tr:selectBooleanCheckbox height
> > 
> > 
> > Hi,
> > 
> > I've observed that the message element for a 
> tr:selectBooleanCheckbox 
> > will be rendered in a table as
> > 
> > <span style="margin-left: 21px;" class="OraInlineErrorText"/>
> > 
> > whereas for all other components it will be rendered as
> > 
> > <span class="OraInlineErrorText"/>.
> > 
> > The additional style attribute causes the span to be visible and 
> > increases the row height, even if no error message will be 
> displayed.
> > 
> > How can I suppress this increase in row height?
> > 
> > --
> > Kind regards,
> > Mathias


RE: [Trinidad] tr:selectBooleanCheckbox height

Posted by "Perkins, Nate-P63196" <Na...@gdc4s.com>.
We solved this by adding this to our skin:

.OraInlineErrorText {
margin-left: 0px! important
} 


Nate Perkins
General Dynamics C4 Systems

-----Original Message-----
From: Mathias Walter [mailto:mathias.walter@gmx.net] 
Sent: Wednesday, July 02, 2008 11:16 AM
To: 'MyFaces Discussion'
Subject: RE: [Trinidad] tr:selectBooleanCheckbox height

Hi,

I forgot to mention the environment: FireFox 2 and 3. The row height
increase does not occur with IE6.

--
Kind regards,
Mathias

> -----Original Message-----
> From: Mathias Walter [mailto:mathias.walter@gmx.net]
> Sent: Wednesday, July 02, 2008 8:12 PM
> To: 'MyFaces Discussion'
> Subject: [Trinidad] tr:selectBooleanCheckbox height
> 
> 
> Hi,
> 
> I've observed that the message element for a tr:selectBooleanCheckbox 
> will be rendered in a table as
> 
> <span style="margin-left: 21px;" class="OraInlineErrorText"/>
> 
> whereas for all other components it will be rendered as
> 
> <span class="OraInlineErrorText"/>.
> 
> The additional style attribute causes the span to be visible and 
> increases the row height, even if no error message will be displayed.
> 
> How can I suppress this increase in row height?
> 
> --
> Kind regards,
> Mathias


RE: [Trinidad] tr:selectBooleanCheckbox height

Posted by Mathias Walter <ma...@gmx.net>.
Hi,

I forgot to mention the environment: FireFox 2 and 3. The row height
increase does not occur with IE6.

--
Kind regards,
Mathias

> -----Original Message-----
> From: Mathias Walter [mailto:mathias.walter@gmx.net] 
> Sent: Wednesday, July 02, 2008 8:12 PM
> To: 'MyFaces Discussion'
> Subject: [Trinidad] tr:selectBooleanCheckbox height
> 
> 
> Hi,
> 
> I've observed that the message element for a 
> tr:selectBooleanCheckbox will
> be rendered in a table as
> 
> <span style="margin-left: 21px;" class="OraInlineErrorText"/>
> 
> whereas for all other components it will be rendered as
> 
> <span class="OraInlineErrorText"/>.
> 
> The additional style attribute causes the span to be visible 
> and increases
> the row height, even if no error message will be displayed.
> 
> How can I suppress this increase in row height?
> 
> --
> Kind regards,
> Mathias


[Trinidad] tr:selectBooleanCheckbox height

Posted by Mathias Walter <ma...@gmx.net>.
Hi,

I've observed that the message element for a tr:selectBooleanCheckbox will
be rendered in a table as

<span style="margin-left: 21px;" class="OraInlineErrorText"/>

whereas for all other components it will be rendered as

<span class="OraInlineErrorText"/>.

The additional style attribute causes the span to be visible and increases
the row height, even if no error message will be displayed.

How can I suppress this increase in row height?

--
Kind regards,
Mathias