You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/31 13:43:05 UTC

[GitHub] [pulsar] andrasbeni commented on a change in pull request #14804: [Issue 14505] PIP-145: Enable evaluating subscription pattern on broker side

andrasbeni commented on a change in pull request #14804:
URL: https://github.com/apache/pulsar/pull/14804#discussion_r839621226



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/PatternTopicsConsumerImplTest.java
##########
@@ -420,66 +419,6 @@ public void testBinaryProtoToGetTopicsOfNamespaceAll() throws Exception {
         producer4.close();
     }
 

Review comment:
       The methods that these tests verify have been moved to org.apache.pulsar.common.topics.TopicList in order to make them available to both broker and client. 
   So the tests have also been moved to the corresponding test class: TopicListTest.
   The added benefit of this is that the new test class does not start a broker for each test case, so the tests in question will run a few milliseconds faster. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org