You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Wei Deng (JIRA)" <ji...@apache.org> on 2015/11/11 19:53:10 UTC

[jira] [Comment Edited] (CASSANDRA-10582) CorruptSSTableException should print the SS Table Name

    [ https://issues.apache.org/jira/browse/CASSANDRA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000885#comment-15000885 ] 

Wei Deng edited comment on CASSANDRA-10582 at 11/11/15 6:52 PM:
----------------------------------------------------------------

It appears that we have fixed this issue in the uber commit for CASSANDRA-8099 (https://github.com/apache/cassandra/commit/a991b64811f4d6adb6c7b31c0df52288eb06cf19). See this diff:

diff CorruptSSTableException.java /code/cassandra-trunk/src/java/org/apache/cassandra/io/sstable
28c28
<         super(cause);
---
>         super("Corrupted: " + path, cause);

I'd argue that this is important enough (for troubleshooting critical conditions and recovering from them quickly) to back-port this code to 2.1 branch, also it presents almost no risk as it's just a more helpful error message.


was (Author: weideng):
It appears that we have fixed this issue in the uber commit for #8099 (https://github.com/apache/cassandra/commit/a991b64811f4d6adb6c7b31c0df52288eb06cf19). See this diff:

diff CorruptSSTableException.java /code/cassandra-trunk/src/java/org/apache/cassandra/io/sstable
28c28
<         super(cause);
---
>         super("Corrupted: " + path, cause);

I'd argue that this is important enough (for troubleshooting critical conditions and recovering from them quickly) to back-port this code to 2.1 branch, also it presents almost no risk as it's just a more helpful error message.

> CorruptSSTableException should print the SS Table Name
> ------------------------------------------------------
>
>                 Key: CASSANDRA-10582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10582
>             Project: Cassandra
>          Issue Type: Bug
>         Environment: Azure
>            Reporter: Anubhav Kale
>            Priority: Minor
>             Fix For: 3.1
>
>
> We should print the SS Table name that's being reported as corrupt to help with quick recovery.
> INFO  16:32:15  Opening /mnt/cassandra/data/exchangecf/udsuserhourlysnapshot-d1260590711511e587125dc4955cc492/exchangecf-udsuserhourlysnapshot-ka-21214 (23832772 bytes)
> INFO  16:32:15  Opening /mnt/cassandra/data/exchangecf/udsuserhourlysnapshot-d1260590711511e587125dc4955cc492/exchangecf-udsuserhourlysnapshot-ka-18398 (149675 bytes)
> INFO  16:32:15  Opening /mnt/cassandra/data/exchangecf/udsuserhourlysnapshot-d1260590711511e587125dc4955cc492/exchangecf-udsuserhourlysnapshot-ka-23707 (18270 bytes)
> INFO  16:32:15  Opening /mnt/cassandra/data/exchangecf/udsuserhourlysnapshot-d1260590711511e587125dc4955cc492/exchangecf-udsuserhourlysnapshot-ka-13656 (814588 bytes)
> ERROR 16:32:15  Exiting forcefully due to file system exception on startup, disk failure policy "stop"
> org.apache.cassandra.io.sstable.CorruptSSTableException: java.io.EOFException
>         at org.apache.cassandra.io.compress.CompressionMetadata.<init>(CompressionMetadata.java:131) ~[apache-cassandra-2.1.9-SNAPSHOT.jar:2.1.9-SNAPSHOT]
>         at org.apache.cassandra.io.compress.CompressionMetadata.create(CompressionMetadata.java:85) ~[apache-cassandra-2.1.9-SNAPSHOT.jar:2.1.9-SNAPSHOT]
>         at org.apache.cassandra.io.util.CompressedSegmentedFile$Builder.metadata(CompressedSegmentedFile.java:79) ~[apache-cassandra-2.1.9-SNAPSHOT.jar:2.1.9-SNAPSHOT]
>         at org.apache.cassandra.io.util.CompressedPoolingSegmentedFile$Builder.complete(CompressedPoolingSegmentedFile.java:72) ~[apache-cassandra-2.1.9-SNAPSHOT.jar:2.1.9-SNAPSHOT]
>         at



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)