You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/21 02:42:24 UTC
[GitHub] [doris] xiaokang opened a new pull request, #15223: [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL
xiaokang opened a new pull request, #15223:
URL: https://github.com/apache/doris/pull/15223
# Proposed changes
fix conflit name BOOL in odbc sqltypes.h and simdjson element.h. Change BOOL to BOOLEAN in simdjson.
- thirdparty/installed/include/sqltypes.h
> #define BOOL int
- thirdparty/src/simdjson-1.0.2/include/simdjson/dom/element.h
> enum class element_type {
> ARRAY = '[', ///< dom::array
> OBJECT = '{', ///< dom::object
> INT64 = 'l', ///< int64_t
> UINT64 = 'u', ///< uint64_t: any integer that fits in uint64_t but *not* int64_t
> DOUBLE = 'd', ///< double: Any number with a "." or "e" that fits in double.
> STRING = '"', ///< std::string_view
> BOO = 't', ///< bool
> NULL_VALUE = 'n' ///< null
> };
>
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15223: [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15223:
URL: https://github.com/apache/doris/pull/15223#issuecomment-1362288851
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15223: [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15223:
URL: https://github.com/apache/doris/pull/15223#issuecomment-1362288835
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15223: [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15223:
URL: https://github.com/apache/doris/pull/15223#issuecomment-1360818792
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.17 seconds
load time: 669 seconds
storage size: 17123579519 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221221034621_clickbench_pr_65927.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #15223: [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL
Posted by GitBox <gi...@apache.org>.
morningman merged PR #15223:
URL: https://github.com/apache/doris/pull/15223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org