You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "PierreSmits (via GitHub)" <gi...@apache.org> on 2024/04/11 07:53:53 UTC

[PR] Improved: have profileMenuLocation (OFBIZ-12981) [ofbiz-plugins]

PierreSmits opened a new pull request, #106:
URL: https://github.com/apache/ofbiz-plugins/pull/106

   Profile screens are used in various components as portalpageportlets, and have references to various party menus. As menus in the various profile screens are parameterized to use ${parameters.mainMenuLocation} this generates errors in the components/applications where these screens are used as portal page elements. Having a context-param profileMenuLocation resolves this issue.
   
   modified:
   myportal-web.xml: have contex-param profileMenuLocation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: have profileMenuLocation (OFBIZ-12981) [ofbiz-plugins]

Posted by "PierreSmits (via GitHub)" <gi...@apache.org>.
PierreSmits commented on PR #106:
URL: https://github.com/apache/ofbiz-plugins/pull/106#issuecomment-2051898172

   Closing this. Time for a do-over as it is giving to much headache.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: have profileMenuLocation (OFBIZ-12981) [ofbiz-plugins]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #106:
URL: https://github.com/apache/ofbiz-plugins/pull/106#issuecomment-2049134916

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=106) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=106&resolved=false&inNewCodePeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=106&metric=new_accepted_issues&view=list)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=106&resolved=false&inNewCodePeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Coverage  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=106&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=106)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: have profileMenuLocation (OFBIZ-12981) [ofbiz-plugins]

Posted by "PierreSmits (via GitHub)" <gi...@apache.org>.
PierreSmits commented on PR #106:
URL: https://github.com/apache/ofbiz-plugins/pull/106#issuecomment-2050202806

   Hi @JacquesLeRoux 
   
   I did not. As the changes in this are in the web.xml file, which only affect the UI side and not any tests.
   
   However, I just ran the test against the main branch (trunk, up tp date per 07:00 this morning) and it failed. So something before that moment must have gone wrong in FixedAssetMaintTests.groovy


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: have profileMenuLocation (OFBIZ-12981) [ofbiz-plugins]

Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #106:
URL: https://github.com/apache/ofbiz-plugins/pull/106#issuecomment-2051056159

   Hi Pierre,
   
   > the changes in this are in the web.xml file, which only affect the UI side and not any tests.
   
   Wrong you also modified FixedAssetMaintTests and it's different than locally. 
   To run the tests I'd need to patch locally. I have enough on my plate. So my question remains: 
   >did you run gradlew "ofbiz --test component=assetmain" ? (in your branch)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: have profileMenuLocation (OFBIZ-12981) [ofbiz-plugins]

Posted by "PierreSmits (via GitHub)" <gi...@apache.org>.
PierreSmits commented on PR #106:
URL: https://github.com/apache/ofbiz-plugins/pull/106#issuecomment-2050225439

   Did you run the test(s)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: have profileMenuLocation (OFBIZ-12981) [ofbiz-plugins]

Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #106:
URL: https://github.com/apache/ofbiz-plugins/pull/106#issuecomment-2049866579

   Thanks Pierre, the AssetMaint integration tests pass?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: have profileMenuLocation (OFBIZ-12981) [ofbiz-plugins]

Posted by "PierreSmits (via GitHub)" <gi...@apache.org>.
PierreSmits commented on PR #106:
URL: https://github.com/apache/ofbiz-plugins/pull/106#issuecomment-2049977721

   HI @JacquesLeRoux,
   
   the AssetMaint integration aspect got **accidentally** in this, but is something you committed to the main branch 4 days ago via https://github.com/apache/ofbiz-plugins/commit/21aff950ea312d20df33aebda2dd25053792f797
   
   I apologize if some things got crossed.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: have profileMenuLocation (OFBIZ-12981) [ofbiz-plugins]

Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #106:
URL: https://github.com/apache/ofbiz-plugins/pull/106#issuecomment-2050021271

   I meant: did you run `gradlew "ofbiz --test component=assetmain"` ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: have profileMenuLocation (OFBIZ-12981) [ofbiz-plugins]

Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #106:
URL: https://github.com/apache/ofbiz-plugins/pull/106#issuecomment-2051861753

   With https://issues.apache.org/jira/browse/OFBIZ-12985
   we have completly fixed all the integration tests. Why would you want to change
   assetmaint/src/main/groovy/org/apache/ofbiz/assetmaint/assetmaint/test/FixedAssetMaintTests.groovy?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: have profileMenuLocation (OFBIZ-12981) [ofbiz-plugins]

Posted by "PierreSmits (via GitHub)" <gi...@apache.org>.
PierreSmits closed pull request #106: Improved: have profileMenuLocation (OFBIZ-12981)
URL: https://github.com/apache/ofbiz-plugins/pull/106


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: have profileMenuLocation (OFBIZ-12981) [ofbiz-plugins]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #106:
URL: https://github.com/apache/ofbiz-plugins/pull/106#issuecomment-2049691706

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=106) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=106&resolved=false&inNewCodePeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=106&metric=new_accepted_issues&view=list)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=106&resolved=false&inNewCodePeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Coverage  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=106&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=106)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org