You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/10 13:43:20 UTC
[jira] [Commented] (KAFKA-4283) records deleted from
CachingKeyValueStore still appear in range and all queries
[ https://issues.apache.org/jira/browse/KAFKA-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15562344#comment-15562344 ]
ASF GitHub Bot commented on KAFKA-4283:
---------------------------------------
GitHub user dguy opened a pull request:
https://github.com/apache/kafka/pull/2001
KAFKA-4283: records deleted from CachingKeyValueStore still appear in range and all queries
Records that are deleted/removed from the CachingKeyValueStore shouldn't appear in range and all queries.
Modified the iterator such that it skips over the deleted records.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dguy/kafka kafka-4283
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2001.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2001
----
commit e75f8c315b91a04a7b66ffa88a8bf83b973cb99c
Author: Damian Guy <da...@gmail.com>
Date: 2016-10-10T13:39:47Z
skip items that have been deleted from the cache in queries
----
> records deleted from CachingKeyValueStore still appear in range and all queries
> -------------------------------------------------------------------------------
>
> Key: KAFKA-4283
> URL: https://issues.apache.org/jira/browse/KAFKA-4283
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 0.10.1.0
> Reporter: Damian Guy
> Assignee: Damian Guy
> Fix For: 0.10.1.1
>
>
> Records deleted from CachingKeyValueStore appear in range and all queries. The deleted record is replaced with an LRUCacheEntry(null), so that when a flush happens the deletion can be sent downstream and removed from the underlying store.
> As this is valid and needed, the iterator used when querying a cached store needs to be aware of the entries where LRUCacheEntry.value == null and skip over them
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)