You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/04 16:01:00 UTC

[GitHub] [spark] Yikun commented on a change in pull request #35640: [SPARK-38187][K8S] Support resource reservation with volcano implementations

Yikun commented on a change in pull request #35640:
URL: https://github.com/apache/spark/pull/35640#discussion_r819695448



##########
File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/VolcanoSuite.scala
##########
@@ -25,6 +30,25 @@ class VolcanoSuite extends KubernetesSuite with VolcanoTestsSuite {
     sparkAppConf
       .set("spark.kubernetes.driver.scheduler.name", "volcano")
       .set("spark.kubernetes.executor.scheduler.name", "volcano")
+    testGroups = mutable.Set.empty
+  }
+
+  private def deletePodInTestGroup(): Unit = {

Review comment:
       FYI, These code also submited into a separate PR: https://github.com/apache/spark/pull/35733




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org