You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 07:57:02 UTC
[I] Proxy gRPC metric settings should tolerate invalid collector address [rocketmq]
Aias00 opened a new issue, #10788:
URL: https://github.com/apache/rocketmq/issues/10788
## Problem
`GrpcClientSettingsManager.mergeMetric(...)` parses the configured metric collector address with a raw split:
```java
String[] split = metricCollectorAddress.split(":");
String host = split[0];
int port = Integer.parseInt(split[1]);
```
When `metricCollectorMode=on` but `metricCollectorAddress` is blank or malformed, the settings merge path can throw `ArrayIndexOutOfBoundsException` or `NumberFormatException`. That can break gRPC client settings generation instead of returning a controlled metric setting.
## Expected behavior
Proxy should not fail client settings merge because of an invalid optional metric collector address. It should validate the address, log a clear warning, and disable metric collection for that settings response when the address cannot be parsed.
## Scope
Track 2 / Proxy gRPC client diagnostics and robustness. This only hardens metric endpoint parsing in gRPC client settings and should not change valid `host:port` handling.
## Evidence
- `proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/common/GrpcClientSettingsManager.java`
- `mergeMetric(...)` reads `metricCollectorAddress.split(":")` and indexes `split[1]` without validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Proxy gRPC metric settings should tolerate invalid collector address [rocketmq]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #10788:
URL: https://github.com/apache/rocketmq/issues/10788#issuecomment-5210876800
The fix proposal for this issue was posted **4 days ago** and no community feedback has been received. Per the automated workflow policy (72h timeout), this proposal is now expired.
If you still want this fix to be implemented, please reply with `/approve` to restart the PR generation process.
---
*Automated timeout notice by @RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Proxy gRPC metric settings should tolerate invalid collector address [rocketmq]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #10788:
URL: https://github.com/apache/rocketmq/issues/10788#issuecomment-5163818683
**Issue Evaluation**
Category: `type/bug` | Status: **Confirmed**
The reported issue has been verified against the current codebase (`develop@eddb235c1bd8`).
**Root Cause:** `GrpcClientSettingsManager.mergeMetric(...)` calls `metricCollectorAddress.split(":")` and directly indexes `split[1]` without validating that the address is non-blank or contains a colon. When `metricCollectorMode=ON` and the address is blank or malformed, this throws `ArrayIndexOutOfBoundsException` or `NumberFormatException`.
**Impact:** gRPC client settings generation fails entirely when metric collector address is misconfigured, instead of gracefully degrading.
**Severity:** medium — requires misconfiguration to trigger, but the failure is uncontrolled.
**File:** `proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/common/GrpcClientSettingsManager.java` (lines 120-122)
An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation.
---
*Automated evaluation by github-manager-bot*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Proxy gRPC metric settings should tolerate invalid collector address [rocketmq]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #10788:
URL: https://github.com/apache/rocketmq/issues/10788#issuecomment-5244919630
**Feedback Timeout**\n\nNo feedback was received within 72 hours. The automated fix proposal has been closed.\n\nIf you'd like to proceed with a fix, please reply to this issue and a maintainer will review it.\n\n---\n*Automated timeout by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org