You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/01 14:26:22 UTC

[GitHub] [iceberg] rymurr commented on pull request #1843: Support for file paths in SparkCatalogs via HadoopTables

rymurr commented on pull request #1843:
URL: https://github.com/apache/iceberg/pull/1843#issuecomment-736584986


   I have added `ALTER` tests and have skipped `DROP` when using SessionCatalog. I have also used @RussellSpitzer's suggestion for implementation. Its a lot cleaner and smaller but means we cant perform certain operations on filesystem tables: some transactions, renames and list by namespace.
   
   I am not a huge fan of identifying a path based table by simply checking if there is a `/` in the name. Any thoughts on how to make this less fragile?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org