[jira] [Commented] (PHOENIX-1892) Don't use alias in TableRef equality check if null

["Maryann Xue (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503337#comment-14503337 ] 

Maryann Xue commented on PHOENIX-1892:
--------------------------------------

[~jamestaylor] Is the alias comparison causing any problem? Not sure about all failures, there might be some other issues in the code revealed by this patch. But I would not agree with this change either, since:
1) A lot of places use TableRef alias if it is available otherwise the table name, which means two TableRefs with and without an alias are treated differently.
2) We can make up an IN subquery case like "select * from atable where entity_id in (select entity_id from atable where a_string = 'a')", and this would fail (verified) because we convert the subquery into a semi-join and create a temp alias for the inner query TableRef (since it's anonymous).

> Don't use alias in TableRef equality check if null
> --------------------------------------------------
>
>                 Key: PHOENIX-1892
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1892
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>         Attachments: PHOENIX-1892.patch
>
>
> If either side of a TableRef has a null alias, it seems like the equality check shouldn't fail in this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)