You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by pa...@apache.org on 2023/05/14 09:23:03 UTC

[shardingsphere] branch master updated: Fix sonar issue of Add at least one assertion to this test case (#25657)

This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 4477ecf95d6 Fix sonar issue of Add at least one assertion to this test case (#25657)
4477ecf95d6 is described below

commit 4477ecf95d60e63c3f353e4721b22ca81c2e5bbd
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sun May 14 17:22:55 2023 +0800

    Fix sonar issue of Add at least one assertion to this test case (#25657)
---
 .../engine/validator/dml/ShardingCopyStatementValidatorTest.java      | 4 ++--
 .../shardingsphere/driver/jdbc/adapter/ConnectionAdapterTest.java     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/validator/dml/ShardingCopyStatementValidatorTest.java b/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/validator/dml/ShardingCopyStatementValidatorTest.java
index 20c8be87b81..d4f09717178 100644
--- a/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/validator/dml/ShardingCopyStatementValidatorTest.java
+++ b/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/validator/dml/ShardingCopyStatementValidatorTest.java
@@ -82,7 +82,7 @@ class ShardingCopyStatementValidatorTest {
         CopyStatementContext sqlStatementContext = new CopyStatementContext(sqlStatement);
         String tableName = "t_order";
         when(shardingRule.isShardingTable(tableName)).thenReturn(true);
-        assertDoesNotThrow(() -> new ShardingCopyStatementValidator().preValidate(
-                shardingRule, sqlStatementContext, Collections.emptyList(), mock(ShardingSphereDatabase.class), mock(ConfigurationProperties.class)));
+        new ShardingCopyStatementValidator().preValidate(
+                shardingRule, sqlStatementContext, Collections.emptyList(), mock(ShardingSphereDatabase.class), mock(ConfigurationProperties.class));
     }
 }
diff --git a/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/adapter/ConnectionAdapterTest.java b/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/adapter/ConnectionAdapterTest.java
index d160eb7cccb..c28375753c5 100644
--- a/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/adapter/ConnectionAdapterTest.java
+++ b/jdbc/core/src/test/java/org/apache/shardingsphere/driver/jdbc/adapter/ConnectionAdapterTest.java
@@ -100,7 +100,7 @@ class ConnectionAdapterTest {
         try (Connection actual = createConnectionAdaptor()) {
             String originalSchema = actual.getSchema();
             actual.setSchema("");
-            assertThat(actual.getSchema(), is(originalSchema));    
+            assertThat(actual.getSchema(), is(originalSchema));
         }
     }