You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by GitBox <gi...@apache.org> on 2021/01/04 18:24:49 UTC
[GitHub] [poi] artragis opened a new pull request #214: poi-ooxml: add new API to add text transparency on XLSX
artragis opened a new pull request #214:
URL: https://github.com/apache/poi/pull/214
This API uses XSSFColor built with alpha channel to set up the right value.
We must take care of the fact Excel uses 1000th of percent and positive numbers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on a change in pull request #214: poi-ooxml: add new API to add text transparency on XLSX
Posted by GitBox <gi...@apache.org>.
pjfanning commented on a change in pull request #214:
URL: https://github.com/apache/poi/pull/214#discussion_r551570755
##########
File path: src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFTextParagraph.java
##########
@@ -863,6 +864,41 @@ private boolean fetchParagraphProperty(ParagraphPropertyFetcher visitor){
return ok;
}
+ public void setTextFillColor(XSSFColor color) {
Review comment:
Probably best to return null if no value is set
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on a change in pull request #214: poi-ooxml: add new API to add text transparency on XLSX
Posted by GitBox <gi...@apache.org>.
pjfanning commented on a change in pull request #214:
URL: https://github.com/apache/poi/pull/214#discussion_r551579754
##########
File path: src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFTextParagraph.java
##########
@@ -863,6 +864,41 @@ private boolean fetchParagraphProperty(ParagraphPropertyFetcher visitor){
return ok;
}
+ public void setTextFillColor(XSSFColor color) {
Review comment:
XSSFColor has `public static XSSFColor from(CTColor color, IndexedColorMap map)` - you can use `new DefaultIndexedColorMap()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] artragis commented on a change in pull request #214: poi-ooxml: add new API to add text transparency on XLSX
Posted by GitBox <gi...@apache.org>.
artragis commented on a change in pull request #214:
URL: https://github.com/apache/poi/pull/214#discussion_r551584317
##########
File path: src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFTextParagraph.java
##########
@@ -863,6 +864,41 @@ private boolean fetchParagraphProperty(ParagraphPropertyFetcher visitor){
return ok;
}
+ public void setTextFillColor(XSSFColor color) {
Review comment:
Ok I will try to build `org.openxmlformats.schemas.spreadsheetml.x2006.main.CTColor` from CTSolidColorFillProperties.
I'm wondering if we cannot create a sub interface for all those colors instead of CTColor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] artragis commented on a change in pull request #214: poi-ooxml: add new API to add text transparency on XLSX
Posted by GitBox <gi...@apache.org>.
artragis commented on a change in pull request #214:
URL: https://github.com/apache/poi/pull/214#discussion_r551577785
##########
File path: src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFTextParagraph.java
##########
@@ -863,6 +864,41 @@ private boolean fetchParagraphProperty(ParagraphPropertyFetcher visitor){
return ok;
}
+ public void setTextFillColor(XSSFColor color) {
Review comment:
Ok, I will try to do so. But translating CTColors into XSSFColor may be hard, Is there any helper to do that in the project?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] artragis commented on a change in pull request #214: poi-ooxml: add new API to add text transparency on XLSX
Posted by GitBox <gi...@apache.org>.
artragis commented on a change in pull request #214:
URL: https://github.com/apache/poi/pull/214#discussion_r551569055
##########
File path: src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFTextParagraph.java
##########
@@ -863,6 +864,41 @@ private boolean fetchParagraphProperty(ParagraphPropertyFetcher visitor){
return ok;
}
+ public void setTextFillColor(XSSFColor color) {
Review comment:
Must I return null if no fill colour is found?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on a change in pull request #214: poi-ooxml: add new API to add text transparency on XLSX
Posted by GitBox <gi...@apache.org>.
pjfanning commented on a change in pull request #214:
URL: https://github.com/apache/poi/pull/214#discussion_r551555862
##########
File path: src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFTextParagraph.java
##########
@@ -863,6 +864,41 @@ private boolean fetchParagraphProperty(ParagraphPropertyFetcher visitor){
return ok;
}
+ public void setTextFillColor(XSSFColor color) {
Review comment:
could you add a getTextFillColor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org