[GitHub] [incubator-skywalking] peng-yongsheng commented on a change in pull request #2411: Divide two static classes

[GitBox <gi...@apache.org>]

peng-yongsheng commented on a change in pull request #2411: Divide two static classes
URL: https://github.com/apache/incubator-skywalking/pull/2411#discussion_r269832323
 
 

 ##########
 File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModule.java
 ##########
 @@ -48,6 +49,9 @@ public CoreModule() {
         classes.add(DownsamplingConfigService.class);
         classes.add(IComponentLibraryCatalogService.class);
 
+        classes.add(IWorkerInstanceGetter.class);
+        classes.add(IWorkerInstanceSetter.class);
 
 Review comment:
   Anything can called manager, but managed what? Interface represent a behavior, so I named the class by his explicit behavior.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services