[jira] [Created] (STORM-3189) Remove unused data file LogViewer api

["Zhengdai Hu (JIRA)" <ji...@apache.org>]

Zhengdai Hu created STORM-3189:
----------------------------------

             Summary: Remove unused data file LogViewer api
                 Key: STORM-3189
                 URL: https://issues.apache.org/jira/browse/STORM-3189
             Project: Apache Storm
          Issue Type: Improvement
          Components: storm-webapp
    Affects Versions: 2.0.0
            Reporter: Zhengdai Hu


Discovered in STORM-3133.

`findNMatches` in LogviewerLogSearchHandler returns a `Matched` object which contains a field `fileOffset`. However, in current implementation, `fileOffset` behaves a bit odd and is not being used anywhere in the app. I'm wondering if we should remove this field altogether

Specifically, the difference in behavior follows,
`fileOffset is passed in as the desired amount of file to skip in search (equiv to index of first file to search)

if desired amount of matches found, fileOffset will be the index of last scanned file (starting from 0).
if not enough matches found in all logs, fileOffset will be number of all logs (equiv to one past the index of last file)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)