[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #104: [SSHD-929] Create separate listener for remove directory.

[GitBox <gi...@apache.org>]

lgoldstein commented on a change in pull request #104: [SSHD-929] Create separate listener for remove directory.
URL: https://github.com/apache/mina-sshd/pull/104#discussion_r296804536
 
 

 ##########
 File path: sshd-sftp/src/main/java/org/apache/sshd/server/subsystem/sftp/AbstractSftpSubsystemHelper.java
 ##########
 @@ -1530,14 +1530,34 @@ protected void doRemoveDirectory(int id, String path, LinkOption... options) thr
     protected void doRemove(int id, Path p) throws IOException {
         SftpEventListener listener = getSftpEventListenerProxy();
         ServerSession session = getServerSession();
-        listener.removing(session, p);
+        boolean isDirectory = Files.isDirectory(p);
 
 Review comment:
   According to the Javadoc:
   
   >> false if the file does not exist, is not a directory, or it cannot be determined if the file is a directory or not.
   
   This means that if file does not exist to begin with we might declare it a"regular" file and signal the incorrect callback.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org