You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2019/12/02 00:40:32 UTC
[commons-statistics] branch master updated (c6b94be -> 21c3821)
This is an automated email from the ASF dual-hosted git repository.
erans pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git.
from c6b94be STATISTICS-21: Probability is zero outside support.
new 95735be Order of arguments in Junit assertions.
new 852ad1a Removed condition that was always true.
new 21c3821 Call "primary" method (to avoid identical implementation).
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../commons/statistics/distribution/LaplaceDistribution.java | 2 +-
.../commons/statistics/distribution/LevyDistribution.java | 2 +-
.../statistics/distribution/LogisticDistribution.java | 2 +-
.../commons/statistics/distribution/ParetoDistribution.java | 2 +-
.../commons/statistics/distribution/PoissonDistribution.java | 4 ++--
.../statistics/distribution/TriangularDistribution.java | 8 ++++----
.../statistics/distribution/BinomialDistributionTest.java | 12 ++++++------
.../statistics/distribution/NakagamiDistributionTest.java | 2 +-
8 files changed, 17 insertions(+), 17 deletions(-)
[commons-statistics] 03/03: Call "primary" method (to avoid
identical implementation).
Posted by er...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git
commit 21c382110ac4106330112497aa03bf9dc2129ebe
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
AuthorDate: Mon Dec 2 01:30:15 2019 +0100
Call "primary" method (to avoid identical implementation).
Reported by "sonarcloud.io".
---
.../apache/commons/statistics/distribution/LaplaceDistribution.java | 2 +-
.../org/apache/commons/statistics/distribution/LevyDistribution.java | 2 +-
.../apache/commons/statistics/distribution/LogisticDistribution.java | 2 +-
.../apache/commons/statistics/distribution/ParetoDistribution.java | 2 +-
.../apache/commons/statistics/distribution/PoissonDistribution.java | 4 ++--
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LaplaceDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LaplaceDistribution.java
index be0fcdf..62e0aad 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LaplaceDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LaplaceDistribution.java
@@ -102,7 +102,7 @@ public class LaplaceDistribution extends AbstractContinuousDistribution {
/** {@inheritDoc} */
@Override
public double getMean() {
- return mu;
+ return getLocation();
}
/** {@inheritDoc} */
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LevyDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LevyDistribution.java
index 289f35e..329a1ad 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LevyDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LevyDistribution.java
@@ -144,7 +144,7 @@ public class LevyDistribution extends AbstractContinuousDistribution {
/** {@inheritDoc} */
@Override
public double getSupportLowerBound() {
- return mu;
+ return getLocation();
}
/** {@inheritDoc} */
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LogisticDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LogisticDistribution.java
index a0c169a..ad6e223 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LogisticDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LogisticDistribution.java
@@ -108,7 +108,7 @@ public class LogisticDistribution extends AbstractContinuousDistribution {
/** {@inheritDoc} */
@Override
public double getMean() {
- return mu;
+ return getLocation();
}
/** {@inheritDoc} */
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/ParetoDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/ParetoDistribution.java
index 8ca9648..052b034 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/ParetoDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/ParetoDistribution.java
@@ -173,7 +173,7 @@ public class ParetoDistribution extends AbstractContinuousDistribution {
*/
@Override
public double getSupportLowerBound() {
- return scale;
+ return getScale();
}
/**
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java
index 215257f..91f3426 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java
@@ -133,11 +133,11 @@ public class PoissonDistribution extends AbstractDiscreteDistribution {
/**
* {@inheritDoc}
*
- * For mean parameter {@code p}, the variance is {@code p}.
+ * The variance is equal to the {@link #getMean() mean}.
*/
@Override
public double getVariance() {
- return mean;
+ return getMean();
}
/**
[commons-statistics] 02/03: Removed condition that was always true.
Posted by er...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git
commit 852ad1a38ad842b04b4e91b531c4832168fd2c81
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
AuthorDate: Mon Dec 2 01:21:11 2019 +0100
Removed condition that was always true.
Reported by "sonarcloud.io".
---
.../commons/statistics/distribution/TriangularDistribution.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TriangularDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TriangularDistribution.java
index 530fd09..7631220 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TriangularDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TriangularDistribution.java
@@ -91,7 +91,7 @@ public class TriangularDistribution extends AbstractContinuousDistribution {
if (x < a) {
return 0;
}
- if (a <= x && x < c) {
+ if (x < c) {
final double divident = 2 * (x - a);
final double divisor = (b - a) * (c - a);
return divident / divisor;
@@ -99,7 +99,7 @@ public class TriangularDistribution extends AbstractContinuousDistribution {
if (x == c) {
return 2 / (b - a);
}
- if (c < x && x <= b) {
+ if (x <= b) {
final double divident = 2 * (b - x);
final double divisor = (b - a) * (b - c);
return divident / divisor;
@@ -125,7 +125,7 @@ public class TriangularDistribution extends AbstractContinuousDistribution {
if (x < a) {
return 0;
}
- if (a <= x && x < c) {
+ if (x < c) {
final double divident = (x - a) * (x - a);
final double divisor = (b - a) * (c - a);
return divident / divisor;
@@ -133,7 +133,7 @@ public class TriangularDistribution extends AbstractContinuousDistribution {
if (x == c) {
return (c - a) / (b - a);
}
- if (c < x && x <= b) {
+ if (x <= b) {
final double divident = (b - x) * (b - x);
final double divisor = (b - a) * (b - c);
return 1 - (divident / divisor);
[commons-statistics] 01/03: Order of arguments in Junit assertions.
Posted by er...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git
commit 95735be6c1d9842b17199544a4ec711b6ff7560e
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
AuthorDate: Mon Dec 2 01:16:48 2019 +0100
Order of arguments in Junit assertions.
Reported by "sonarcloud.io".
---
.../statistics/distribution/BinomialDistributionTest.java | 12 ++++++------
.../statistics/distribution/NakagamiDistributionTest.java | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BinomialDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BinomialDistributionTest.java
index b322a21..c87721d 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BinomialDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BinomialDistributionTest.java
@@ -108,8 +108,8 @@ public class BinomialDistributionTest extends DiscreteDistributionAbstractTest {
verifyDensities();
verifyCumulativeProbabilities();
verifyInverseCumulativeProbabilities();
- Assertions.assertEquals(dist.getSupportLowerBound(), 0);
- Assertions.assertEquals(dist.getSupportUpperBound(), 0);
+ Assertions.assertEquals(0, dist.getSupportLowerBound());
+ Assertions.assertEquals(0, dist.getSupportUpperBound());
}
/** Test degenerate case p = 1 */
@@ -126,8 +126,8 @@ public class BinomialDistributionTest extends DiscreteDistributionAbstractTest {
verifyDensities();
verifyCumulativeProbabilities();
verifyInverseCumulativeProbabilities();
- Assertions.assertEquals(dist.getSupportLowerBound(), 5);
- Assertions.assertEquals(dist.getSupportUpperBound(), 5);
+ Assertions.assertEquals(5, dist.getSupportLowerBound());
+ Assertions.assertEquals(5, dist.getSupportUpperBound());
}
/** Test degenerate case n = 0 */
@@ -144,8 +144,8 @@ public class BinomialDistributionTest extends DiscreteDistributionAbstractTest {
verifyDensities();
verifyCumulativeProbabilities();
verifyInverseCumulativeProbabilities();
- Assertions.assertEquals(dist.getSupportLowerBound(), 0);
- Assertions.assertEquals(dist.getSupportUpperBound(), 0);
+ Assertions.assertEquals(0, dist.getSupportLowerBound());
+ Assertions.assertEquals(0, dist.getSupportUpperBound());
}
@Test
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NakagamiDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NakagamiDistributionTest.java
index c7d010a..50f0cd8 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NakagamiDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NakagamiDistributionTest.java
@@ -35,7 +35,7 @@ public class NakagamiDistributionTest extends ContinuousDistributionAbstractTest
@Test
public void testSupport() {
NakagamiDistribution d = makeDistribution();
- Assertions.assertEquals(d.getSupportLowerBound(), 0, Precision.EPSILON);
+ Assertions.assertEquals(0, d.getSupportLowerBound(), Precision.EPSILON);
Assertions.assertTrue(Double.isInfinite(d.getSupportUpperBound()));
Assertions.assertTrue(d.isSupportConnected());
}