You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/06/29 20:16:54 UTC
Review Request 36010: Updated upgrades.md about Resource API changes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36010/
-----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Bugs: MESOS-2123
https://issues.apache.org/jira/browse/MESOS-2123
Repository: mesos
Description
-------
Updated upgrades.md about Resource API changes.
Diffs
-----
docs/upgrades.md 35e893cf7a1ad01d6298c0e7ecfa3bb084807f1c
Diff: https://reviews.apache.org/r/36010/diff/
Testing
-------
Thanks,
Jie Yu
Re: Review Request 36010: Updated upgrades.md about Resource API
changes.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36010/#review89759
-----------------------------------------------------------
Ship it!
Looking pretty good. Minor suggestions.
docs/upgrades.md (line 17)
<https://reviews.apache.org/r/36010/#comment142552>
s/meta data/metadata/g
s/reservation/reservations/
s/object/objects/
Is this a "Please do not" or a "you cannot" or "you must not"? Will it error? Will things break?
- Adam B
On June 29, 2015, 11:16 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36010/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 11:16 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Bugs: MESOS-2123
> https://issues.apache.org/jira/browse/MESOS-2123
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated upgrades.md about Resource API changes.
>
>
> Diffs
> -----
>
> docs/upgrades.md 35e893cf7a1ad01d6298c0e7ecfa3bb084807f1c
>
> Diff: https://reviews.apache.org/r/36010/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 36010: Updated upgrades.md about Resource API
changes.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36010/
-----------------------------------------------------------
(Updated June 29, 2015, 6:34 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Changes
-------
Adam's comments.
Bugs: MESOS-2123
https://issues.apache.org/jira/browse/MESOS-2123
Repository: mesos
Description
-------
Updated upgrades.md about Resource API changes.
Diffs (updated)
-----
docs/upgrades.md 35e893cf7a1ad01d6298c0e7ecfa3bb084807f1c
Diff: https://reviews.apache.org/r/36010/diff/
Testing
-------
Thanks,
Jie Yu