You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Hiram Chirino (JIRA)" <ji...@apache.org> on 2009/07/16 21:56:14 UTC
[jira] Created: (CASSANDRA-301) Support a maven release
Support a maven release
-----------------------
Key: CASSANDRA-301
URL: https://issues.apache.org/jira/browse/CASSANDRA-301
Project: Cassandra
Issue Type: New Feature
Reporter: Hiram Chirino
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated CASSANDRA-301:
------------------------------------
Attachment: CASSANDRA-301.patch.3
Attaching new patch with:
# jira URL added
# hudson info added
# example of how to keep a contributor list,
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-301:
-------------------------------------
Component/s: Tools
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743287#action_12743287 ]
Michael Greene commented on CASSANDRA-301:
------------------------------------------
+1 on CASSANDRA-301_v6.diff from Carl. Also got a +1 from mmcbride on IRC.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Fix For: 0.4
>
> Attachments: CASSANDRA-301.patch.4, CASSANDRA-301_v5.diff, CASSANDRA-301_v6.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-301:
-------------------------------------
Fix Version/s: 0.4
Per ant's comments on the list, I'm +1 for committing this as-is. It does work and several users have been asking for it, it just doesn't have all the functionality some users are asking for, and we have yet to resolve how to add that functionality.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Fix For: 0.4
>
> Attachments: CASSANDRA-301.patch.4, CASSANDRA-301_v5.diff, CASSANDRA-301_v6.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732143#action_12732143 ]
Hiram Chirino commented on CASSANDRA-301:
-----------------------------------------
You can also generate some nice reports using:
mvn site:site
then open target/site/index.html
Deploy to the website using:
mvn site:site site:deploy
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: pom.xml
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732164#action_12732164 ]
Hiram Chirino commented on CASSANDRA-301:
-----------------------------------------
No each 'release manager' (folks who will be trusted to do releases, any committer can really), should have his own key and the public key and Apache convention is to append it to a the /trunk/KEYS file.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch, CASSANDRA-301.patch.2, pom.xml
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744529#action_12744529 ]
Hudson commented on CASSANDRA-301:
----------------------------------
Integrated in Cassandra #171 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/171/])
fix pom.xml corruption from initial commit
Patch by Mark McBride; reviewed by eevans for
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Assignee: Hiram Chirino
> Fix For: 0.4
>
> Attachments: CASSANDRA-301.patch.4, CASSANDRA-301_v5.diff, CASSANDRA-301_v6.diff, CASSANDRA-301_v7.diff, CASSANDRA_301_v8.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733994#action_12733994 ]
Michael Greene commented on CASSANDRA-301:
------------------------------------------
commons-javaflow should be in a repo somewhere -- they've had Maven support for awhile based on this: http://svn.apache.org/viewvc/commons/sandbox/javaflow/trunk/pom.xml?view=log and it's an ASF project.
libthrift is still waiting on a release, but it shouldn't be tough for someone here to add Maven support to it. There is a JIRA issue open and waiting for it at THRIFT-363
I don't think (A) is going to occur with high-scale-lib based on the do-it-yourself build system they use, but that's just speculation.
We are using an unofficial version of clhm, so there's no way for that to be in an official repo. It is under Apache License 2.0 though. What should Maven do in this case? It seems like a local install is all that can be done.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.4, CASSANDRA-301_v5.diff, CASSANDRA-301_v6.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated CASSANDRA-301:
------------------------------------
Attachment: CASSANDRA-301.patch.4
Attaching version of the pom which uses ant to generate the thrift bits.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-301) Support a maven
release
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732319#action_12732319 ]
Michael Greene edited comment on CASSANDRA-301 at 7/16/09 8:58 PM:
-------------------------------------------------------------------
My previous runs were on Ubuntu, with JDK 1.6. Running on OSX, I don't see the test errors, but I'll have to check that previous computer to figure out what was going on. I still see the JDK errors:
[WARNING] Error while parsing ~/cassandra-301/src/java/org/apache/cassandra/service/ThriftValidation.java: Can't use variable arguments (varargs) when running in JDK 1.4 mode!
[WARNING] Error while parsing ~/cassandra-301/src/java/org/apache/cassandra/service/WriteResponseResolver.java: Can't use generics unless running in JDK 1.5 mode!
However my default JDK is 1.6 and
$ echo $JAVA_HOME
/System/Library/Frameworks/JavaVM.framework/Versions/1.6/Home/
I've needed to export MAVEN_OPTS=-Xmx256M to get the full dependency report to generate when running mvn site:site - is there a way to suggest these JVM args in the pom?
JIRA and Hudson info look good. Could a committer direct Hiram to a committer list? I don't know where a complete list is, just some of the individuals. Also note: the existing patch should not be submitted as-is due to the inclusion of sample data in this list.
I still think we should define the thrift generation in terms of the existing ant tasks, so we don't have to duplicate changes to those in the future.
The patch is shaping up pretty well, and I'm getting introduced to the wonders of Maven in the process. Thanks Hiram!
was (Author: euphoria):
My previous runs were on Ubuntu, with JDK 1.6. Running on OSX, I don't see those errors, but I'll have to check that previous computer to figure out what was going on.
JIRA and Hudson info look good. Could a committer direct Hiram to a committer list? I don't know where a complete list is, just some of the individuals. Also note: the existing patch should not be submitted as-is due to the inclusion of sample data in this list.
I still think we should define the thrift generation in terms of the existing ant tasks, so we don't have to duplicate changes to those in the future.
The patch is shaping up pretty well, and I'm getting introduced to the wonders of Maven in the process. Thanks Hiram!
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732189#action_12732189 ]
Michael Greene commented on CASSANDRA-301:
------------------------------------------
It looks like there is a way to throw JIRA and Hudson in there, can we get those entries added as well? and committers?
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.2
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated CASSANDRA-301:
------------------------------------
Attachment: (was: CASSANDRA-301.patch)
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.2
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-301:
-------------------------------------
Attachment: CASSANDRA-301_v5.diff
New patch to fix my problems with previous patch. It's mostly the same, with a few changes. With this patch, all of my previous reservations have been addressed.
It turns out the file deletion failure is JDK 6 b14-16 dependent, and will be fixed in a newer release: http://sourceforge.net/tracker/?func=detail&aid=2806475&group_id=130558&atid=720017
Changes:
I added a list of active committers, and removed the contributor (sorry Hiram) since it was showing up in the "list of developers with commit privileges" on the site, which isn't accurate.
The tabs/spaces have all been converted to spaces, with no trailing space.
The user mailing list was added, and the information for the other mailing lists was flushed out.
The version was change to 0.4.0-dev. The pom would only work against trunk. If we want to target 0.3.0 we can try to get a version going that will work against the branch.
If someone more familiar with Maven confirms that this will work for them, I'm +1.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.4, CASSANDRA-301_v5.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-301) Support a maven release
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans resolved CASSANDRA-301.
----------------------------------
Resolution: Fixed
Assignee: Michael Greene
committed; thanks.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Assignee: Michael Greene
> Fix For: 0.4
>
> Attachments: CASSANDRA-301.patch.4, CASSANDRA-301_v5.diff, CASSANDRA-301_v6.diff, CASSANDRA-301_v7.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Mark McBride (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark McBride updated CASSANDRA-301:
-----------------------------------
Attachment: CASSANDRA_301_v8.diff
It looks like two patches got applied, resulting in two concatenated poms. Maven doesn't like this much... I attached another patch that chops off the second pom.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Assignee: Hiram Chirino
> Fix For: 0.4
>
> Attachments: CASSANDRA-301.patch.4, CASSANDRA-301_v5.diff, CASSANDRA-301_v6.diff, CASSANDRA-301_v7.diff, CASSANDRA_301_v8.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Mark McBride (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark McBride updated CASSANDRA-301:
-----------------------------------
Attachment: CASSANDRA-301_v7.diff
Made a minor tweak to the last patch, changing outputDirectory to point to the same place ant puts class files. This means you can run the cassandra startup scripts without copying jars around or running an ant build.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Fix For: 0.4
>
> Attachments: CASSANDRA-301.patch.4, CASSANDRA-301_v5.diff, CASSANDRA-301_v6.diff, CASSANDRA-301_v7.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732149#action_12732149 ]
Michael Greene commented on CASSANDRA-301:
------------------------------------------
Should the report generation, and thrift generation, be defined in both the ant build file and the Maven source like this? Is there a way to link those?
What do we do about the GPG key in that releasing doc above? Is that shared amongst committers?
I got the following error:
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to resolve artifact.
Missing:
----------
1) javax.jms:jms:jar:1.1
but other than that things seemed to download. If that errors gets tracked down, I can do further testing.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch, pom.xml
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732319#action_12732319 ]
Michael Greene commented on CASSANDRA-301:
------------------------------------------
My previous runs were on Ubuntu, with JDK 1.6. Running on OSX, I don't see those errors, but I'll have to check that previous computer to figure out what was going on.
JIRA and Hudson info look good. Could a committer direct Hiram to a committer list? I don't know where a complete list is, just some of the individuals. Also note: the existing patch should not be submitted as-is due to the inclusion of sample data in this list.
I still think we should define the thrift generation in terms of the existing ant tasks, so we don't have to duplicate changes to those in the future.
The patch is shaping up pretty well, and I'm getting introduced to the wonders of Maven in the process. Thanks Hiram!
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated CASSANDRA-301:
------------------------------------
Attachment: CASSANDRA-301.patch.2
attaching better pom. To fix the jms dependency issue.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch, CASSANDRA-301.patch.2, pom.xml
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated CASSANDRA-301:
------------------------------------
Attachment: (was: pom.xml)
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.2
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated CASSANDRA-301:
------------------------------------
Attachment: CASSANDRA-301.patch
putting pom in a diff format.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch, pom.xml
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743697#action_12743697 ]
Hudson commented on CASSANDRA-301:
----------------------------------
Integrated in Cassandra #168 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/168/])
support a maven release (pom.xml)
Patch by Hiram Chirino, Michael Greene, Carl Byström, and Mark McBride;
reviewed by eevans for
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Assignee: Hiram Chirino
> Fix For: 0.4
>
> Attachments: CASSANDRA-301.patch.4, CASSANDRA-301_v5.diff, CASSANDRA-301_v6.diff, CASSANDRA-301_v7.diff, CASSANDRA_301_v8.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732180#action_12732180 ]
Michael Greene commented on CASSANDRA-301:
------------------------------------------
That fixes the dependency issue, yes.
I get the following when running 'mvn site:site'
...
[WARNING] Error while parsing /home/cassandra/review/cassandra-297/src/java/org/apache/cassandra/utils/ReducingIterator.java: Can't use generics unless running in JDK 1.5 mode!
...
[WARNING] Error while parsing /home/cassandra/review/cassandra-297/src/java/org/apache/cassandra/utils/TimedStatsDeque.java: Can't use generics unless running in JDK 1.5 mode!
... etc. Is there a way to make sure that it runs this in JDK 1.6 or JDK 1.7 mode? Cassandra only supports 1.6+
Also, if I run 'mvn install' and then 'mvn site:site' all of the tests fail on a file delete. Not sure if this is a mvn issue or not.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.2
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743242#action_12743242 ]
Jonathan Ellis commented on CASSANDRA-301:
------------------------------------------
Which patch version are you +1 on committing?
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Fix For: 0.4
>
> Attachments: CASSANDRA-301.patch.4, CASSANDRA-301_v5.diff, CASSANDRA-301_v6.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732307#action_12732307 ]
Hiram Chirino commented on CASSANDRA-301:
-----------------------------------------
what's your committer roll?
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.2
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Carl Byström (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Byström updated CASSANDRA-301:
-----------------------------------
Attachment: CASSANDRA-301_v6.diff
Added an updated POM based on Michael's version. Managed to find the Groovy and google-collection deps in an official repo.
There are still problems with the dependencies. Some deps (clhm, high-scale-lib, libthrift, commons-javaflow) don't exist in official repos.
I guess Hiram added these as "system" deps because they couldn't be found elsewhere. But this creates a problem where the generated artifacts expects to find these deps on the end-users computer (that's what the <scope>-tag says with "system"). Normally, Maven would go look in it's repos for the missing artifact and resolve it.
With Cassandra being something that people will include as a dependency, they expect the everything to resolve. Listing deps as "system" is usually only done with deps having special licenses that forbid them to be distributed by normal Maven repos.
The way I see it, following options exist:
A) Convince the developers of these libraries to put the right version in an official repo.
B) Package the library ourselves and submit to an official repo.
C) Package the library ourselves but add it to the Apache repo along with Cassandra.
D) Package the library ourselves and host it in a 3rd party repository (forcing users of the cassandra dep to add this repo to their repo list)
Unfortunately, the only viable solutions is A. (Perhaps B, not sure if a random person can submit deps to the official repos)
Without these missing deps readily available to Maven users of Cassandra, things will not work (unless they of course manually import these "system" deps by hand).
Perhaps there are ways around this with Maven, I don't know. Been using it for a couple of years but only for internal projects where we maintain our own private repo.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.4, CASSANDRA-301_v5.diff, CASSANDRA-301_v6.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744085#action_12744085 ]
Eric Evans commented on CASSANDRA-301:
--------------------------------------
Thanks for the heads up; patch (CASSANDRA_301_v8.diff) applied.
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Assignee: Hiram Chirino
> Fix For: 0.4
>
> Attachments: CASSANDRA-301.patch.4, CASSANDRA-301_v5.diff, CASSANDRA-301_v6.diff, CASSANDRA-301_v7.diff, CASSANDRA_301_v8.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated CASSANDRA-301:
------------------------------------
Attachment: pom.xml
Attaching maven pom.
To build run:
mvn install
To generate thrift source files run
mvn -P thrift
To release, follow the procedures at:
http://maven.apache.org/developers/release/releasing.html
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: pom.xml
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated CASSANDRA-301:
------------------------------------
Attachment: (was: CASSANDRA-301.patch.2)
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-301:
---------------------------------
Assignee: Hiram Chirino (was: Michael Greene)
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Assignee: Hiram Chirino
> Fix For: 0.4
>
> Attachments: CASSANDRA-301.patch.4, CASSANDRA-301_v5.diff, CASSANDRA-301_v6.diff, CASSANDRA-301_v7.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-301) Support a maven release
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated CASSANDRA-301:
------------------------------------
Attachment: (was: CASSANDRA-301.patch.3)
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-301) Support a maven release
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732306#action_12732306 ]
Hiram Chirino commented on CASSANDRA-301:
-----------------------------------------
I don't get that warning. Then again I'm running on 1.6 JDK. The pom is configured to use the 1.6 compiler.
As for the 'tests fail on a file delete' does not happen for me. I'm guessing your on windows (it has stricter file delete operations). Wonder what file that is..
> Support a maven release
> -----------------------
>
> Key: CASSANDRA-301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-301
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Hiram Chirino
> Attachments: CASSANDRA-301.patch.2
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.