You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by markap14 <gi...@git.apache.org> on 2017/12/22 14:11:35 UTC
[GitHub] nifi pull request #2359: NIFI-4717: [More Testing Needed] Several minor bug ...
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2359
NIFI-4717: [More Testing Needed] Several minor bug fixes and performance improvements aroun…
…d record-oriented processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4717
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2359.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2359
----
commit 57a5a09fe91dce191fc459745dfa343f1578ee85
Author: Mark Payne <ma...@...>
Date: 2017-12-21T17:31:32Z
NIFI-4717: Several minor bug fixes and performance improvements around record-oriented processors
----
---
[GitHub] nifi issue #2359: NIFI-4717: [More Testing Needed] Several minor bug fixes a...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2359
+1 LGTM, ran a full build with contrib-check and unit tests, and tried UpdateRecord and QueryRecord with various schemas, Readers/Writers, with/out Expression Language, etc. I didn't do any explicit performance testing (metrics, e.g.) but it did seem to perform faster. Thanks for the improvements! Merging to master
---
[GitHub] nifi pull request #2359: NIFI-4717: [More Testing Needed] Several minor bug ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2359
---
[GitHub] nifi issue #2359: NIFI-4717: [More Testing Needed] Several minor bug fixes a...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2359
I have done a decent bit of local testing but would like to perform more testing before merging this to master. Creating pull request so that those who may be interested can test to see how this affects performance and ensure that all is still correct.
---
[GitHub] nifi issue #2359: NIFI-4717: [More Testing Needed] Several minor bug fixes a...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2359
Reviewing...
---