You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/01/05 14:52:46 UTC
[GitHub] flink pull request #3066: [FLINK-5160] [refactor] SecurityUtils use Operatin...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3066
[FLINK-5160] [refactor] SecurityUtils use OperatingSystem.getCurrentOperatingSys\u2026
This is a follow-up refactoring to #2888 proposed by @StephanEwen .
It changes the `SecurityUtils#getOSUserName` method to use no longer parse the OS name itself but instead rely on the `OperatingSystem.getCurrentOperatingSystem` utility method.
The `OperatingSystem` enum had to be extended to include the Solaris OS since the affected code had a branch for it. The parsing for it was simply copied.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 5160_follow_up
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3066.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3066
----
commit 7b635f7504146871818453961c1d441b55b175a2
Author: zentol <ch...@apache.org>
Date: 2017-01-05T14:39:25Z
[FLINK-5160] SecurityUtils use OperatingSystem.getCurrentOperatingSystem()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3066: [FLINK-5160] [refactor] SecurityUtils use OperatingSystem...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3066
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3066: [FLINK-5160] [refactor] SecurityUtils use OperatingSystem...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3066
Looks good to me, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3066: [FLINK-5160] [refactor] SecurityUtils use Operatin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3066
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---