You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/08/08 11:19:19 UTC

[GitHub] [fineract] SubhamPramanik opened a new pull request #1816: User interop creation when registering send service user

SubhamPramanik opened a new pull request #1816:
URL: https://github.com/apache/fineract/pull/1816


   ## Description
   
   Describe the changes made and why they were made.
   
   -PR registers Mobile Number as user interior identifier when self service user is created with a savings account. 
   
   Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [x] Create/update unit or integration tests for verifying the changes made.
   
   - [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
   
   - [x] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] github-actions[bot] commented on pull request #1816: User interop creation when registering send service user

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1816:
URL: https://github.com/apache/fineract/pull/1816#issuecomment-915654920


   This pull request seems to be stale.  Are you still planning to work on it?  We will automatically close it in 30 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] github-actions[bot] closed pull request #1816: User interop creation when registering send service user

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1816:
URL: https://github.com/apache/fineract/pull/1816


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] awasum commented on pull request #1816: User interop creation when registering send service user

Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1816:
URL: https://github.com/apache/fineract/pull/1816#issuecomment-895158580


   Thanks for your contributions. What problem are you trying to solve? Can you describe in a JIRA ticket? https://issues.apache.org/jira/browse/FINERACT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] awasum commented on pull request #1816: User interop creation when registering send service user

Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1816:
URL: https://github.com/apache/fineract/pull/1816#issuecomment-895159053


   You should also rebase your work on top of develop branch as this has merge conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org