You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/03/10 22:27:55 UTC

[GitHub] sdalu commented on issue #901: ble service: Device Information Service

sdalu commented on issue #901: ble service: Device Information Service
URL: https://github.com/apache/mynewt-core/pull/901#issuecomment-372072137
 
 
   * I think "Model Number", "Manufacturer Name" will generally be know at compile time and won't change, so I don't feel comfortable at preallocating memory as for the Device Name in GAP. Is there a preprocessor trick to do conditional with string value?
   * For the Firmware/Software we could use the image versioning, but I'm not sure which one makes more sense. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services