You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Greg Stein <gs...@lyra.org> on 2000/11/22 23:36:58 UTC
Re: cvs commit: apache-2.0/src/modules/standard mod_autoindex.c mod_dir.c mod_negotiation.c
Your change isn't quite complete. I see the following files also use
ap_sub_req_*:
standard/mod_cern_meta.c
standard/mod_rewrite.c
test/mod_autoindex.c
dav/main/props.c
dav/main/util.c
os/win32/mod_isapi.c
[ I didn't look, but I presume the mod_include you checked in has the extra
param ]
Cheers,
-g
On Wed, Nov 22, 2000 at 07:38:10PM -0000, rbb@locus.apache.org wrote:
> rbb 00/11/22 11:38:10
>
> Modified: src CHANGES
> src/include http_request.h
> src/main http_core.c http_request.c util_script.c
> src/modules/standard mod_autoindex.c mod_dir.c
> mod_negotiation.c
> Log:
> Allow modules to specify the first module for a sub-request. This allows
> modules to not have to muck with the output_filter after it creates the
> sub-request. Without this change, modules that create a sub-request have
> to manually edit the output_filters, and therefore skip the sub-request
> output_filter. If they skip the sub-request output_filter, then we end
> up sending multiple EOS buckets to the core_output_filter.
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: apache-2.0/src/modules/standard mod_autoindex.c
mod_dir.c mod_negotiation.c
Posted by rb...@covalent.net.
> > > standard/mod_cern_meta.c
> > > standard/mod_rewrite.c
> > > test/mod_autoindex.c
> > > dav/main/props.c
> > > dav/main/util.c
> > > os/win32/mod_isapi.c
> >
> > Okay, I missed all those. I thought I configured all of the modules, but
> > I guess I missed those. Do you want to deal with this, or should I just
> > fix it.
>
> I did a recursive grep rather than build :-)
Probably a bit smarter. I wanted to get the thing committed, good thing
we didn't roll the alpha. :-)
> No problem, I can handle it.
Thanks, I'm trying to add a simple configuration option before I leave
town until Sunday. :-)
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: cvs commit: apache-2.0/src/modules/standard mod_autoindex.c mod_dir.c mod_negotiation.c
Posted by Greg Stein <gs...@lyra.org>.
On Wed, Nov 22, 2000 at 02:40:26PM -0800, rbb@covalent.net wrote:
> On Wed, 22 Nov 2000, Greg Stein wrote:
>
> > Your change isn't quite complete. I see the following files also use
> > ap_sub_req_*:
> >
> > standard/mod_cern_meta.c
> > standard/mod_rewrite.c
> > test/mod_autoindex.c
> > dav/main/props.c
> > dav/main/util.c
> > os/win32/mod_isapi.c
>
> Okay, I missed all those. I thought I configured all of the modules, but
> I guess I missed those. Do you want to deal with this, or should I just
> fix it.
I did a recursive grep rather than build :-)
No problem, I can handle it.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: apache-2.0/src/modules/standard mod_autoindex.c
mod_dir.c mod_negotiation.c
Posted by rb...@covalent.net.
On Wed, 22 Nov 2000, Greg Stein wrote:
> Your change isn't quite complete. I see the following files also use
> ap_sub_req_*:
>
> standard/mod_cern_meta.c
> standard/mod_rewrite.c
> test/mod_autoindex.c
> dav/main/props.c
> dav/main/util.c
> os/win32/mod_isapi.c
Okay, I missed all those. I thought I configured all of the modules, but
I guess I missed those. Do you want to deal with this, or should I just
fix it.
> [ I didn't look, but I presume the mod_include you checked in has the extra
> param ]
Yep.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------