[jira] [Commented] (OAK-6956) RepositoryUpgrade hardcodes SecurityProvider

["Alex Deparvu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-6956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406090#comment-16406090 ] 

Alex Deparvu commented on OAK-6956:
-----------------------------------

proposed patch based on latest development of the security provider bits ( [^OAK-6956.patch] ). this removes the usage of the impl class, but doesn't not address one of the issues raised here: what happens to custom setups. If I understand correctly this revolves around the method that transforms old JR config into the new format based on config params ({{mapSecurityConfig}} method). if there's a custom case to be treated, I would expect the {{mapSecurityConfig}} method to evolve to fit the new case in and pass the correct settings to the security provider builder.

> RepositoryUpgrade hardcodes SecurityProvider
> --------------------------------------------
>
>                 Key: OAK-6956
>                 URL: https://issues.apache.org/jira/browse/OAK-6956
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: upgrade
>            Reporter: angela
>            Assignee: Tomek Rękawek
>            Priority: Critical
>             Fix For: 1.9.0, 1.10
>
>         Attachments: OAK-6956.patch
>
>
> [~tomek.rekawek] Looking at non-test usage of the (to be deprecated) {{SecurityProviderImpl}} I noticed one usage in the {{RepositoryUpgrade}} that looks troublesome to me.
> I would strongly recommend to fix that given the fact that we no longer use {{SecurityProviderImpl}} in production ready setup scenarios.
> cc: [~stillalex]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)