You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/09/04 07:43:26 UTC
[GitHub] [kyuubi] pan3793 opened a new pull request, #5246: [KYUUBI #5138][TEST] Fix flaky test BatchesResourceSuite - get batch session list
pan3793 opened a new pull request, #5246:
URL: https://github.com/apache/kyuubi/pull/5246
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
```
override def afterEach(): Unit = {
val sessionManager = fe.be.sessionManager.asInstanceOf[KyuubiSessionManager]
sessionManager.allSessions().foreach { session =>
sessionManager.closeSession(session.handle)
}
// there is a chance that `KyuubiBatchService` do batch job submission during this phase
// which causes the above cleanup can not catch all sessions.
sessionManager.getBatchesFromMetadataStore(MetadataFilter(), 0, Int.MaxValue).foreach { batch =>
sessionManager.applicationManager.killApplication(ApplicationManagerInfo(None), batch.getId)
sessionManager.cleanupMetadata(batch.getId)
}
}
```
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
### _Was this patch authored or co-authored using generative AI tooling?_
<!--
If a generative AI tooling has been used in the process of authoring this patch, please include
phrase 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #5246: [KYUUBI #5138][TEST] Fix flaky test BatchesResourceSuite - get batch session list
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #5246: [KYUUBI #5138][TEST] Fix flaky test BatchesResourceSuite - get batch session list
URL: https://github.com/apache/kyuubi/pull/5246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #5246: [KYUUBI #5138][TEST] Fix flaky test BatchesResourceSuite - get batch session list
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5246:
URL: https://github.com/apache/kyuubi/pull/5246#issuecomment-1705240798
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5246](https://app.codecov.io/gh/apache/kyuubi/pull/5246?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0c418b4) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/6061a05f2469a39b6b9e4c39488104362cdd2494?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6061a05) will **not change** coverage.
> Report is 3 commits behind head on master.
> The diff coverage is `n/a`.
> :exclamation: Current head 0c418b4 differs from pull request most recent head a8d6837. Consider uploading reports for the commit a8d6837 to get more accurate results
```diff
@@ Coverage Diff @@
## master #5246 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 590 590
Lines 33344 33344
Branches 4403 4403
======================================
Misses 33344 33344
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #5246: [KYUUBI #5138][TEST] Fix flaky test BatchesResourceSuite - get batch session list
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5246:
URL: https://github.com/apache/kyuubi/pull/5246#issuecomment-1705440573
Thanks, merged to master/1.8, will keep eye on the stability of CI on master branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org