[GitHub] [beam] aromanenko-dev commented on a change in pull request #14338: [BEAM-12044] JdbcIO read: always force autocommit to false

[GitBox <gi...@apache.org>]

aromanenko-dev commented on a change in pull request #14338:
URL: https://github.com/apache/beam/pull/14338#discussion_r601762732



##########
File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -903,6 +903,8 @@ public void processElement(ProcessContext context) throws Exception {
       if (connection == null) {
         connection = dataSource.getConnection();
       }
+      // PostgreSQL requires autocommit to be disabled to enable cursor streaming

Review comment:
       I'd suggest to set it to `false` only if it was not explicitly set to `true` by connection properties configuration. Otherwise, it won't be possible to override and it can be confusing for users.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org