[GitHub] [arrow-rs] viirya commented on pull request #1767: Remove `validate_decimal_precision` check in `DecimalBuilder.append_value`

[GitBox <gi...@apache.org>]

viirya commented on PR #1767:
URL: https://github.com/apache/arrow-rs/pull/1767#issuecomment-1141848938

   In C++, the similar check is done in validating ArrayData, not during appending values into the builder. I'm not sure which one is more correct under Arrow's context.
   
   I'm trying to remove the check and (not committed yet) put the precision check into the validation of ArrayData (this is what C++ Arrow does).
   
   In one way, as we don't do full validation when finishing the builder, it seems this check is necessary if it is the promise of the builder to always build a valid ArrayData. Then the check is needed and it seems C++ needs to add the check there. I will open a ticket there and try to get some feedbacks.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org