You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/16 14:14:34 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #11579: Accessibility Fix: State token contrast
ryanahamilton opened a new pull request #11579:
URL: https://github.com/apache/airflow/pull/11579
The `state_token` utility that renders the labels depicted below was failing contrast ratio standards for the "success" and "failed" states. There was already a preexisting `color_fg` method in place to handle the foreground color used for these two instances, it just wasn't employed in this utility (until now).
| Before | After |
|---|---|
| <img width="166" alt="Image 2020-10-16 at 10 07 35 AM" src="https://user-images.githubusercontent.com/3267/96268841-8a516300-0f97-11eb-8205-1fabb5bbe779.png"> | <img width="169" alt="Image 2020-10-16 at 9 55 27 AM" src="https://user-images.githubusercontent.com/3267/96268623-45c5c780-0f97-11eb-9039-6d2f39699dfa.png"> |
| Before | After |
|---|---|
| <img width="118" alt="Image 2020-10-16 at 10 07 46 AM" src="https://user-images.githubusercontent.com/3267/96268858-8f161700-0f97-11eb-9d78-fea8ec34b779.png"> | <img width="131" alt="Image 2020-10-16 at 9 57 54 AM" src="https://user-images.githubusercontent.com/3267/96268598-4199aa00-0f97-11eb-90b2-cb0e7c1bc4ea.png"> |
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #11579: Accessibility Fix: State token contrast
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #11579:
URL: https://github.com/apache/airflow/pull/11579#issuecomment-710117331
Random failures - one 137, one random non 200 response. Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #11579: Accessibility Fix: State token contrast
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #11579:
URL: https://github.com/apache/airflow/pull/11579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org