You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/06/25 13:04:03 UTC
[GitHub] [submarine] cdmikechen opened a new pull request, #972: SUBMARINE-1288. Fix issue that agent can not stop after Kubeflow job is finished
cdmikechen opened a new pull request, #972:
URL: https://github.com/apache/submarine/pull/972
### What is this PR for?
With new training operator replaced, the Kubeflow CRD status conditions reason description has changed. We need to modify the processing of the state, so that the agent can stop correctly.
### What type of PR is it?
Bug Fix
### Todos
* [x] - Change the reason name in training operator
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1288
### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
### Screenshots (if appropriate)
No
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #972: SUBMARINE-1288. Fix issue that agent can not stop after Kubeflow job is finished
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #972:
URL: https://github.com/apache/submarine/pull/972#issuecomment-1166284767
# [Codecov](https://codecov.io/gh/apache/submarine/pull/972?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#972](https://codecov.io/gh/apache/submarine/pull/972?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d2ffcbf) into [master](https://codecov.io/gh/apache/submarine/commit/37fb84235461494d9813c9a72a8719b878083fa9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37fb842) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head d2ffcbf differs from pull request most recent head 3a61aa0. Consider uploading reports for the commit 3a61aa0 to get more accurate results
```diff
@@ Coverage Diff @@
## master #972 +/- ##
========================================
Coverage 9.21% 9.21%
Complexity 670 670
========================================
Files 230 230
Lines 23628 23628
Branches 3461 3461
========================================
Hits 2178 2178
Misses 21319 21319
Partials 131 131
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/submarine/pull/972?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/submarine/pull/972?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [37fb842...3a61aa0](https://codecov.io/gh/apache/submarine/pull/972?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #972: SUBMARINE-1288. Fix issue that agent can not stop after Kubeflow job is finished
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #972: SUBMARINE-1288. Fix issue that agent can not stop after Kubeflow job is finished
URL: https://github.com/apache/submarine/pull/972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org