You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/09 07:39:54 UTC
[GitHub] [incubator-inlong] shink opened a new pull request, #4609: [INLONG-4606][CI] Improve trigger conditions
shink opened a new pull request, #4609:
URL: https://github.com/apache/incubator-inlong/pull/4609
Fixes: #4606
### Motivation
Improve trigger conditions.
### Modifications
Improve trigger conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #4609: [INLONG-4606][CI] Improve trigger conditions
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #4609:
URL: https://github.com/apache/incubator-inlong/pull/4609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4609: [INLONG-4606][CI] Improve trigger conditions
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4609:
URL: https://github.com/apache/incubator-inlong/pull/4609#discussion_r893274866
##########
.github/workflows/ci_docker.yml:
##########
@@ -21,36 +21,24 @@ on:
push:
paths:
- '.github/workflows/ci_docker.yml'
- - '**/pom.xml'
- - 'inlong-agent/**'
- - 'inlong-audit/**'
- - 'inlong-common/**'
- - 'inlong-dashboard/**'
- - 'inlong-dataproxy/**'
- - 'inlong-distribution/**'
- - 'inlong-manager/**'
- - 'inlong-sdk/**'
- - 'inlong-sort/**'
- - 'inlong-sort-standalone/**'
- - 'inlong-tubemq/**'
- - '!*.md'
+ - '**/Dockerfile'
+ - 'inlong-agent/agent-docker/**'
+ - 'inlong-audit/audit-docker/**'
+ - 'inlong-dataproxy/dataproxy-docker/**'
+ - 'inlong-manager/manager-docker/**'
+ - 'inlong-tubemq/tubemq-docker/**'
+ - '!**.md'
pull_request:
paths:
- '.github/workflows/ci_docker.yml'
- - '**/pom.xml'
- - 'inlong-agent/**'
- - 'inlong-audit/**'
- - 'inlong-common/**'
- - 'inlong-dashboard/**'
- - 'inlong-dataproxy/**'
- - 'inlong-distribution/**'
- - 'inlong-manager/**'
- - 'inlong-sdk/**'
- - 'inlong-sort/**'
- - 'inlong-sort-standalone/**'
- - 'inlong-tubemq/**'
- - '!*.md'
+ - '**/Dockerfile'
+ - 'inlong-agent/agent-docker/**'
+ - 'inlong-audit/audit-docker/**'
+ - 'inlong-dataproxy/dataproxy-docker/**'
+ - 'inlong-manager/manager-docker/**'
+ - 'inlong-tubemq/tubemq-docker/**'
+ - '!**.md'
Review Comment:
Great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on a diff in pull request #4609: [INLONG-4606][CI] Improve trigger conditions
Posted by GitBox <gi...@apache.org>.
shink commented on code in PR #4609:
URL: https://github.com/apache/incubator-inlong/pull/4609#discussion_r893176241
##########
.github/workflows/ci_build.yml:
##########
@@ -33,7 +33,7 @@ on:
- 'inlong-sort/**'
- 'inlong-sort-standalone/**'
- 'inlong-tubemq/**'
- - '!*.md'
+ - '!**.md'
Review Comment:
The difference between the two is: `*.md` only matches all `.md` files at the root of the repository, and `**.md` matches all `.md` files in the repository. See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#patterns-to-match-file-paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on a diff in pull request #4609: [INLONG-4606][CI] Improve trigger conditions
Posted by GitBox <gi...@apache.org>.
shink commented on code in PR #4609:
URL: https://github.com/apache/incubator-inlong/pull/4609#discussion_r893176241
##########
.github/workflows/ci_build.yml:
##########
@@ -33,7 +33,7 @@ on:
- 'inlong-sort/**'
- 'inlong-sort-standalone/**'
- 'inlong-tubemq/**'
- - '!*.md'
+ - '!**.md'
Review Comment:
The difference between the two is: `*.md` only matches all `.md` files at the root of the repository, and `**.md` matches all `.md` files in the repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on a diff in pull request #4609: [INLONG-4606][CI] Improve trigger conditions
Posted by GitBox <gi...@apache.org>.
shink commented on code in PR #4609:
URL: https://github.com/apache/incubator-inlong/pull/4609#discussion_r893176763
##########
.github/workflows/ci_docker.yml:
##########
@@ -21,36 +21,24 @@ on:
push:
paths:
- '.github/workflows/ci_docker.yml'
- - '**/pom.xml'
- - 'inlong-agent/**'
- - 'inlong-audit/**'
- - 'inlong-common/**'
- - 'inlong-dashboard/**'
- - 'inlong-dataproxy/**'
- - 'inlong-distribution/**'
- - 'inlong-manager/**'
- - 'inlong-sdk/**'
- - 'inlong-sort/**'
- - 'inlong-sort-standalone/**'
- - 'inlong-tubemq/**'
- - '!*.md'
+ - '**/Dockerfile'
+ - 'inlong-agent/agent-docker/**'
+ - 'inlong-audit/audit-docker/**'
+ - 'inlong-dataproxy/dataproxy-docker/**'
+ - 'inlong-manager/manager-docker/**'
+ - 'inlong-tubemq/tubemq-docker/**'
+ - '!**.md'
pull_request:
paths:
- '.github/workflows/ci_docker.yml'
- - '**/pom.xml'
- - 'inlong-agent/**'
- - 'inlong-audit/**'
- - 'inlong-common/**'
- - 'inlong-dashboard/**'
- - 'inlong-dataproxy/**'
- - 'inlong-distribution/**'
- - 'inlong-manager/**'
- - 'inlong-sdk/**'
- - 'inlong-sort/**'
- - 'inlong-sort-standalone/**'
- - 'inlong-tubemq/**'
- - '!*.md'
+ - '**/Dockerfile'
+ - 'inlong-agent/agent-docker/**'
+ - 'inlong-audit/audit-docker/**'
+ - 'inlong-dataproxy/dataproxy-docker/**'
+ - 'inlong-manager/manager-docker/**'
+ - 'inlong-tubemq/tubemq-docker/**'
+ - '!**.md'
Review Comment:
@healchow PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org