You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/21 21:36:34 UTC

[GitHub] [superset] junlincc commented on pull request #15820: fix: Render value immediately on SQL Editor for Calculated Columns in Edit Dataset modal

junlincc commented on pull request #15820:
URL: https://github.com/apache/superset/pull/15820#issuecomment-884516079


   @geido thanks for fixing the issue and spinning up the testenv for the team  🙏
   
   LGTM ✅
   After 
   
   https://user-images.githubusercontent.com/67837651/126563272-cccf5cda-71a8-40c6-93d6-6d0878ed93b8.mov
   
   Before
   
   https://user-images.githubusercontent.com/67837651/126563297-b826b9b7-3123-41e5-bc41-1cab78889a5e.mov
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org