You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Jim Blandy <ji...@zwingli.cygnus.com> on 2000/11/13 17:22:34 UTC
Re: CVS update: subversion/subversion/libsvn_fs convert-size.c convert-size.h dir.c id.c id.h skel.c skel.h txn.c
I don't think constifying the skel functions is right, as explained in
this comment in skel.h:
You'd think that DATA would be a `const char *', but we want to
create `skel' structures that point into it, and a skel's DATA
pointer shouldn't be a `const char *', since that would constrain
how the caller can use the structure. We only want to say that
*we* won't change it --- we don't want to prevent the caller from
changing it --- but C's type system doesn't allow us to say that. */
A skel_t's .data pointer should be a const char *. I'll fix it up.