You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/12/07 08:50:42 UTC

[GitHub] [incubator-mxnet] leezu edited a comment on issue #17003: Release prebuild binary of cpp

leezu edited a comment on issue #17003: Release prebuild binary of cpp
URL: https://github.com/apache/incubator-mxnet/issues/17003#issuecomment-562829966
 
 
   I don't think shipping a precompiled libraries is a good solution for C++. It relies on implementation (compiler) defined ABI and may break at any point. You can take a look at [P1863R0](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1863r0.pdf).
   
   Instead, how about we improve the `CMakeLists.txt`, so that MXNet can easily be integrated in other projects that use cmake. https://cliutils.gitlab.io/modern-cmake/ is a good reference. Would that solve your concerns? The idea is that in the end you only need to do add the following line to the `CMakeLists.txt` of your own project: `add_subdirectory(3rdparty/mxnet)` ([reference](https://cliutils.gitlab.io/modern-cmake/chapters/projects/submodule.html))

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services