You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/23 06:23:53 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #612:
Refine POSTBUILD for spresense and esp32-core
xiaoxiang781216 opened a new pull request #612: Refine POSTBUILD for spresense and esp32-core
URL: https://github.com/apache/incubator-nuttx/pull/612
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #612:
Refine POSTBUILD for spresense and esp32-core
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #612: Refine POSTBUILD for spresense and esp32-core
URL: https://github.com/apache/incubator-nuttx/pull/612#discussion_r396256743
##########
File path: boards/xtensa/esp32/esp32-core/Kconfig
##########
@@ -38,4 +38,10 @@ config ESP32CORE_RUN_IRAM
allows interoperability with the esp-idf system but makes you
reliant on the esp-idf design for these parts. Both are possible.
+config ESP32CORE_BINARY
+ bool "esp32 binary format"
Review comment:
this is misleading as it's just a flash image.
how about "Flash image (mainly for QEMU)"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea edited a comment on issue #612: Refine
POSTBUILD for spresense and esp32-core
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on issue #612: Refine POSTBUILD for spresense and esp32-core
URL: https://github.com/apache/incubator-nuttx/pull/612#issuecomment-602572077
+1 but it failed the checks and I am unable to test locally due to network constrain
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #612: Refine POSTBUILD for spresense and esp32-core
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #612: Refine POSTBUILD for spresense and esp32-core
URL: https://github.com/apache/incubator-nuttx/pull/612#discussion_r396335751
##########
File path: boards/xtensa/esp32/esp32-core/Kconfig
##########
@@ -38,4 +38,10 @@ config ESP32CORE_RUN_IRAM
allows interoperability with the esp-idf system but makes you
reliant on the esp-idf design for these parts. Both are possible.
+config ESP32CORE_BINARY
+ bool "esp32 binary format"
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #612: Refine POSTBUILD
for spresense and esp32-core
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #612: Refine POSTBUILD for spresense and esp32-core
URL: https://github.com/apache/incubator-nuttx/pull/612
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on issue #612: Refine POSTBUILD
for spresense and esp32-core
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #612: Refine POSTBUILD for spresense and esp32-core
URL: https://github.com/apache/incubator-nuttx/pull/612#issuecomment-602754432
> Will the build tests restart automatically so that we can confirm that?
I re-run the CI checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #612: Refine
POSTBUILD for spresense and esp32-core
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #612: Refine POSTBUILD for spresense and esp32-core
URL: https://github.com/apache/incubator-nuttx/pull/612#issuecomment-602572077
+1 but it failed the checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea edited a comment on issue #612: Refine
POSTBUILD for spresense and esp32-core
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on issue #612: Refine POSTBUILD for spresense and esp32-core
URL: https://github.com/apache/incubator-nuttx/pull/612#issuecomment-602572077
+1 but it failed the checks and I am unable to test locally due to network constrains
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services