You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/05 05:41:03 UTC

[GitHub] [hudi] yihua opened a new pull request, #5750: [HUDI-4190] Include hbase-protocol for shading in the bundles

yihua opened a new pull request, #5750:
URL: https://github.com/apache/hudi/pull/5750

   ## What is the purpose of the pull request
   
   This PR addresses the `ClassNotFoundException` for HBase classes from `hbase-protocol` (which are not included in the bundles), reported by #5496.
   
   ## Brief change log
   
     - Add the entry of `org.apache.hbase:hbase-protocol` as an `include` rule for shading in the bundles
   
   ## Verify this pull request
   
   After this change, by running the following command to check the shaded classes, the proto classes are found:
   ```
   > jar tf packaging/hudi-spark-bundle/target/hudi-spark3.2-bundle_2.12-0.12.0-SNAPSHOT.jar | grep org/apache/hudi/org/apache/hadoop/hbase/protobuf
   ...
   org/apache/hudi/org/apache/hadoop/hbase/protobuf/generated/AuthenticationProtos$TokenIdentifier.class
   ...
   ```
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #5750: [HUDI-4190] Include hbase-protocol for shading in the bundles

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5750:
URL: https://github.com/apache/hudi/pull/5750#issuecomment-1146754015

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35a3b934c200191b46eba0dd278032b7ad27958d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9078",
       "triggerID" : "35a3b934c200191b46eba0dd278032b7ad27958d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35a3b934c200191b46eba0dd278032b7ad27958d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9078) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #5750: [HUDI-4190] Include hbase-protocol for shading in the bundles

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5750:
URL: https://github.com/apache/hudi/pull/5750#issuecomment-1146777759

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35a3b934c200191b46eba0dd278032b7ad27958d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35a3b934c200191b46eba0dd278032b7ad27958d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35a3b934c200191b46eba0dd278032b7ad27958d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #5750: [HUDI-4190] Include hbase-protocol for shading in the bundles

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5750:
URL: https://github.com/apache/hudi/pull/5750#issuecomment-1146785131

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35a3b934c200191b46eba0dd278032b7ad27958d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9078",
       "triggerID" : "35a3b934c200191b46eba0dd278032b7ad27958d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35a3b934c200191b46eba0dd278032b7ad27958d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9078) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] nsivabalan commented on pull request #5750: [HUDI-4190] Include hbase-protocol for shading in the bundles

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5750:
URL: https://github.com/apache/hudi/pull/5750#issuecomment-1147358612

   @xushiyan @yihua : Do we need to call out anything in 0.11 docs wrt this. anything to call out which may not work. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] yihua commented on pull request #5750: [HUDI-4190] Include hbase-protocol for shading in the bundles

Posted by GitBox <gi...@apache.org>.
yihua commented on PR #5750:
URL: https://github.com/apache/hudi/pull/5750#issuecomment-1169613800

   @nsivabalan this fixes a particular use case wrt kerberos authentication.  No need to call it out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #5750: [HUDI-4190] Include hbase-protocol for shading in the bundles

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5750:
URL: https://github.com/apache/hudi/pull/5750#issuecomment-1146749226

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35a3b934c200191b46eba0dd278032b7ad27958d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9078",
       "triggerID" : "35a3b934c200191b46eba0dd278032b7ad27958d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35a3b934c200191b46eba0dd278032b7ad27958d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9078) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #5750: [HUDI-4190] Include hbase-protocol for shading in the bundles

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5750:
URL: https://github.com/apache/hudi/pull/5750#issuecomment-1146748863

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35a3b934c200191b46eba0dd278032b7ad27958d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35a3b934c200191b46eba0dd278032b7ad27958d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35a3b934c200191b46eba0dd278032b7ad27958d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #5750: [HUDI-4190] Include hbase-protocol for shading in the bundles

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5750:
URL: https://github.com/apache/hudi/pull/5750#issuecomment-1146778305

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35a3b934c200191b46eba0dd278032b7ad27958d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9078",
       "triggerID" : "35a3b934c200191b46eba0dd278032b7ad27958d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35a3b934c200191b46eba0dd278032b7ad27958d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9078) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] xushiyan commented on pull request #5750: [HUDI-4190] Include hbase-protocol for shading in the bundles

Posted by GitBox <gi...@apache.org>.
xushiyan commented on PR #5750:
URL: https://github.com/apache/hudi/pull/5750#issuecomment-1146922088

   https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9078
   CI passed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] xushiyan merged pull request #5750: [HUDI-4190] Include hbase-protocol for shading in the bundles

Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #5750:
URL: https://github.com/apache/hudi/pull/5750


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org