[GitHub] [hadoop] zhtttylz commented on pull request #5743: HDFS-17049. EC: Fix duplicate block group IDs generated by SequentialBlockGroupIdGenerator.

["zhtttylz (via GitHub)" <gi...@apache.org>]

zhtttylz commented on PR #5743:
URL: https://github.com/apache/hadoop/pull/5743#issuecomment-1590809127

   @zhangshuyan0 Thank you very much for your valuable time. I would like to inquire about the concurrency issue in **SequentialBlockGroupIdGenerator#nextValue**. It seems that **FSNamesystem#nextBlockId** verifies **FSNamesystemLock#writeLock**.
   ```java
     Block createNewBlock(BlockType blockType) throws IOException {
       assert hasWriteLock();
       Block b = new Block(nextBlockId(blockType), 0, 0);
       // Increment the generation stamp for every new block.
       b.setGenerationStamp(nextGenerationStamp(false));
       return b;
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org