You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/06 00:15:09 UTC

[GitHub] [beam] lostluck commented on a change in pull request #13013: [BEAM-11019] Fixing Go SDF progress reporting with multiple windows.

lostluck commented on a change in pull request #13013:
URL: https://github.com/apache/beam/pull/13013#discussion_r499939012



##########
File path: sdks/go/pkg/beam/core/runtime/exec/pardo.go
##########
@@ -134,40 +134,40 @@ func (n *ParDo) processMainInput(mainIn *MainInput) error {
 	// If the function observes windows, we must invoke it for each window. The expected fast path
 	// is that either there is a single window or the function doesn't observes windows.

Review comment:
       Consider amending the comment here making the optimization explicit.
   ...doesn't observe windows meaning they can be computed simultaneously.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org