You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/10/04 23:34:03 UTC

[kudu-CR] [java client] Rename NoLeaderMasterFoundException and reuse 

Jean-Daniel Cryans has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4624

Change subject: [java client] Rename NoLeaderMasterFoundException and reuse
......................................................................

[java client] Rename NoLeaderMasterFoundException and reuse

I pushed d87486c too fast, Dan convinced me to reuse the exception

Change-Id: I51ad20943fe8b4b808123dc8b7795215f3b12308
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationReceived.java
R java/kudu-client/src/main/java/org/apache/kudu/client/NoLeaderFoundException.java
M java/kudu-client/src/main/java/org/apache/kudu/client/NoSuitableReplicaException.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestGetMasterRegistrationReceived.java
6 files changed, 19 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/4624/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I51ad20943fe8b4b808123dc8b7795215f3b12308
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>

[kudu-CR] [java client] Rename NoLeaderMasterFoundException and reuse

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: [java client] Rename NoLeaderMasterFoundException and reuse
......................................................................


[java client] Rename NoLeaderMasterFoundException and reuse

I pushed d87486c too fast, Dan convinced me to reuse the exception.

Change-Id: I51ad20943fe8b4b808123dc8b7795215f3b12308
Reviewed-on: http://gerrit.cloudera.org:8080/4624
Reviewed-by: Dan Burkert <da...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationReceived.java
R java/kudu-client/src/main/java/org/apache/kudu/client/NoLeaderFoundException.java
D java/kudu-client/src/main/java/org/apache/kudu/client/NoSuitableReplicaException.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestGetMasterRegistrationReceived.java
6 files changed, 14 insertions(+), 46 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I51ad20943fe8b4b808123dc8b7795215f3b12308
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java client] Rename NoLeaderMasterFoundException and reuse

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4624

to look at the new patch set (#2).

Change subject: [java client] Rename NoLeaderMasterFoundException and reuse
......................................................................

[java client] Rename NoLeaderMasterFoundException and reuse

I pushed d87486c too fast, Dan convinced me to reuse the exception.

Change-Id: I51ad20943fe8b4b808123dc8b7795215f3b12308
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationReceived.java
R java/kudu-client/src/main/java/org/apache/kudu/client/NoLeaderFoundException.java
D java/kudu-client/src/main/java/org/apache/kudu/client/NoSuitableReplicaException.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestGetMasterRegistrationReceived.java
6 files changed, 14 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/4624/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51ad20943fe8b4b808123dc8b7795215f3b12308
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java client] Rename NoLeaderMasterFoundException and reuse

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: [java client] Rename NoLeaderMasterFoundException and reuse
......................................................................


Patch Set 1: Code-Review+2

I'm assuming you want to keep around NoSuitableReplicaException for future use?

-- 
To view, visit http://gerrit.cloudera.org:8080/4624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51ad20943fe8b4b808123dc8b7795215f3b12308
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [java client] Rename NoLeaderMasterFoundException and reuse

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: [java client] Rename NoLeaderMasterFoundException and reuse
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51ad20943fe8b4b808123dc8b7795215f3b12308
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [java client] Rename NoLeaderMasterFoundException and reuse

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: [java client] Rename NoLeaderMasterFoundException and reuse
......................................................................


Patch Set 1:

> I'm assuming you want to keep around NoSuitableReplicaException for
 > future use?

Argh no, forgot to delete.

-- 
To view, visit http://gerrit.cloudera.org:8080/4624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51ad20943fe8b4b808123dc8b7795215f3b12308
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No