[GitHub] GabeLoins commented on a change in pull request #5204: [explore] fix autocomplete on verbose names

[GitBox <gi...@apache.org>]

GabeLoins commented on a change in pull request #5204: [explore] fix autocomplete on verbose names
URL: https://github.com/apache/incubator-superset/pull/5204#discussion_r195575617
 
 

 ##########
 File path: superset/assets/src/explore/components/controls/MetricsControl.jsx
 ##########
 @@ -224,8 +224,13 @@ export default class MetricsControl extends React.PureComponent {
         (option.column_name.toLowerCase().indexOf(valueAfterAggregate.toLowerCase()) >= 0);
     }
     return option.optionName &&
-      (!option.metric_name || !this.isAutoGeneratedMetric(option)) &&
 
 Review comment:
   in the metrics control you can select saved_metrics, columns, or aggregates from the dropdown. That's why I use `optionName` for comparison rather than metric name. In that check I'm saying `if the option is not a saved metric,  or if it is a saved metric but not an autogenerated saved metric`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org