You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2018/07/25 02:56:00 UTC
[jira] [Resolved] (ARROW-2701) [C++] Make MemoryMappedFile
resizable
[ https://issues.apache.org/jira/browse/ARROW-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wes McKinney resolved ARROW-2701.
---------------------------------
Resolution: Fixed
Issue resolved by pull request 2205
[https://github.com/apache/arrow/pull/2205]
> [C++] Make MemoryMappedFile resizable
> -------------------------------------
>
> Key: ARROW-2701
> URL: https://issues.apache.org/jira/browse/ARROW-2701
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Affects Versions: 0.9.0
> Reporter: Dimitri Vorona
> Assignee: Dimitri Vorona
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
> Time Spent: 11h 10m
> Remaining Estimate: 0h
>
> Hi,
> I don't see any reason for the MemoryMappedFile not to be resizable, e.g. like it is in Python stdlib. This patch changes the base class of MemoryMappedFile to ResizableBuffer and implements mmap resizing similar to [mmap.resize|https://github.com/python/cpython/blob/415bc46a78e785f357c8960ae70f18a6b6cccbb6/Modules/mmapmodule.c#L454] from python stdlib.
> If the change is ok, we should probably change the comment [here|https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_io.py#L577], too.
> Cheers,
> Dimitri.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)