You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/25 13:38:17 UTC

[GitHub] [flink] RyanSkraba commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet

RyanSkraba commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1004501592


##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/protobuf/ParquetProtoStreamingFileSinkITCase.java:
##########
@@ -49,13 +50,12 @@
  * Simple integration test case for writing bulk encoded files with the {@link StreamingFileSink}
  * with Parquet.
  */
-public class ParquetProtoStreamingFileSinkITCase extends AbstractTestBase {
-
-    @Rule public final Timeout timeoutPerTest = Timeout.seconds(20);
+@ExtendWith(MiniClusterExtension.class)

Review Comment:
   There is a difference: `@RegisterExtension` allows you to tune the minicluster (in this case, `AvroParquetFileReadITCase` has some parallelism tests that will fail with the default number of slots). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org