You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Blair Zajac <bl...@orcaware.com> on 2002/08/01 01:10:07 UTC
Re: [PATCH] apr_pools.c patch for bounds checking compiler
Blair Zajac wrote:
>
> I'm using the bounds checking gcc 3.1.1 to check for memory issues
> in Apache and Subversion. This patch to gcc compiles the code with
> extra checks for illegal memory accesses, invalid pointers, etc and
> runs a lot faster than valgrind. See
>
> http://web.inter.nl.net/hcc/Haj.Ten.Brugge/
>
> There's a core dump from the bounds checking compiler when running
> httpd -l with today's HEAD
>
Here's an updated patch with an additional change that was caught with
Subversion's make check, replacing
- if (!ps->got_a_new_node && node->first_avail + size < node->endp) {
with
+ if (!ps->got_a_new_node && node->endp - node->first_avail > size) {
Best,
Blair
--
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
RE: [PATCH] apr_pools.c patch for bounds checking compiler
Posted by Sander Striker <st...@apache.org>.
> From: Blair Zajac [mailto:blair@orcaware.com]
> Sent: 06 August 2002 19:53
> Sander Striker wrote:
>>> Blair Zajac wrote:
>>>> I'm using the bounds checking gcc 3.1.1 to check for memory issues
>>>> in Apache and Subversion. This patch to gcc compiles the code with
>>>> extra checks for illegal memory accesses, invalid pointers, etc and
>> [...]
>>
>> Hi Blair,
>>
>> Thanks for the patch. I'll review and commit this within a day or two.
>>
>> Sander
>
> Hi Sander,
>
> Have you had an opportunity to review the patch?
Yes, I have. Thanks for reminding me that I still need to integrate and
commit it ;).
Sander
Re: [PATCH] apr_pools.c patch for bounds checking compiler
Posted by Blair Zajac <bl...@orcaware.com>.
Sander Striker wrote:
>
> > From: Blair Zajac [mailto:blair@orcaware.com]
> > Sent: 06 August 2002 19:53
>
> > Sander Striker wrote:
> > >
> > > > From: Blair Zajac [mailto:blair@orcaware.com]
> > > > Sent: 01 August 2002 01:10
> > >
> > > > Blair Zajac wrote:
> > > >>
> > > >> I'm using the bounds checking gcc 3.1.1 to check for memory issues
> > > >> in Apache and Subversion. This patch to gcc compiles the code with
> > > >> extra checks for illegal memory accesses, invalid pointers, etc and
> > > [...]
> > >
> > > Hi Blair,
> > >
> > > Thanks for the patch. I'll review and commit this within a day or two.
> > >
> > > Sander
> >
> > Hi Sander,
> >
> > Have you had an opportunity to review the patch?
>
> Applied. Thanks!
>
> Sander
Great! Thanks.
Blair
--
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
RE: [PATCH] apr_pools.c patch for bounds checking compiler
Posted by Sander Striker <st...@apache.org>.
> From: Blair Zajac [mailto:blair@orcaware.com]
> Sent: 06 August 2002 19:53
> Sander Striker wrote:
> >
> > > From: Blair Zajac [mailto:blair@orcaware.com]
> > > Sent: 01 August 2002 01:10
> >
> > > Blair Zajac wrote:
> > >>
> > >> I'm using the bounds checking gcc 3.1.1 to check for memory issues
> > >> in Apache and Subversion. This patch to gcc compiles the code with
> > >> extra checks for illegal memory accesses, invalid pointers, etc and
> > [...]
> >
> > Hi Blair,
> >
> > Thanks for the patch. I'll review and commit this within a day or two.
> >
> > Sander
>
> Hi Sander,
>
> Have you had an opportunity to review the patch?
Applied. Thanks!
Sander
Re: [PATCH] apr_pools.c patch for bounds checking compiler
Posted by Blair Zajac <bl...@orcaware.com>.
Sander Striker wrote:
>
> > From: Blair Zajac [mailto:blair@orcaware.com]
> > Sent: 01 August 2002 01:10
>
> > Blair Zajac wrote:
> >>
> >> I'm using the bounds checking gcc 3.1.1 to check for memory issues
> >> in Apache and Subversion. This patch to gcc compiles the code with
> >> extra checks for illegal memory accesses, invalid pointers, etc and
> [...]
>
> Hi Blair,
>
> Thanks for the patch. I'll review and commit this within a day or two.
>
> Sander
Hi Sander,
Have you had an opportunity to review the patch?
Best,
Blair
--
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
RE: [PATCH] apr_pools.c patch for bounds checking compiler
Posted by Sander Striker <st...@apache.org>.
> From: Blair Zajac [mailto:blair@orcaware.com]
> Sent: 01 August 2002 01:10
> Blair Zajac wrote:
>>
>> I'm using the bounds checking gcc 3.1.1 to check for memory issues
>> in Apache and Subversion. This patch to gcc compiles the code with
>> extra checks for illegal memory accesses, invalid pointers, etc and
[...]
Hi Blair,
Thanks for the patch. I'll review and commit this within a day or two.
Sander