You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "gohalo (via GitHub)" <gi...@apache.org> on 2024/08/21 07:12:51 UTC
[PR] feat: support external config hudi-defaults.conf [hudi-rs]
gohalo opened a new pull request, #117:
URL: https://github.com/apache/hudi-rs/pull/117
## Description
Support [externalized config file](https://hudi.apache.org/cn/docs/configurations/#externalized-config-file), you could define global config file `hudi-defaults.conf` with the following format.
```
# Comments and empty lines will ignore
hoodie.datasource.write.operation upsert
hoodie.datasource.write.table.type=MERGE_ON_READ
# The following without config value is invalid, and will ignore
hoodie.metrics.on
```
details could check issue #111
## How are the changes test-covered
- [ ] N/A
- [x] Automated tests (unit and/or integration tests)
- [ ] Manual tests
- [ ] Details are described below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: extract common test code for creating table [hudi-rs]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan merged PR #117:
URL: https://github.com/apache/hudi-rs/pull/117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support external config hudi-defaults.conf [hudi-rs]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #117:
URL: https://github.com/apache/hudi-rs/pull/117#issuecomment-2302672084
## [Codecov](https://app.codecov.io/gh/apache/hudi-rs/pull/117?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `73.33333%` with `4 lines` in your changes missing coverage. Please review.
> Project coverage is 87.13%. Comparing base [(`5bf117a`)](https://app.codecov.io/gh/apache/hudi-rs/commit/5bf117a85c50bd848d51ee81d4dc20202ceae8bd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`234dbf8`)](https://app.codecov.io/gh/apache/hudi-rs/commit/234dbf89722c7f914c582f6f0a23a41e18f0fd86?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files](https://app.codecov.io/gh/apache/hudi-rs/pull/117?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [crates/core/src/table/mod.rs](https://app.codecov.io/gh/apache/hudi-rs/pull/117?src=pr&el=tree&filepath=crates%2Fcore%2Fsrc%2Ftable%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3JhdGVzL2NvcmUvc3JjL3RhYmxlL21vZC5ycw==) | 73.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi-rs/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 87.42% 87.13% -0.30%
==========================================
Files 14 14
Lines 700 715 +15
==========================================
+ Hits 612 623 +11
- Misses 88 92 +4
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/hudi-rs/pull/117?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support external config hudi-defaults.conf [hudi-rs]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #117:
URL: https://github.com/apache/hudi-rs/pull/117#discussion_r1759458623
##########
crates/core/src/table/mod.rs:
##########
@@ -631,22 +609,13 @@ mod tests {
configs.get(TableType).unwrap().to::<String>(),
"COPY_ON_WRITE"
);
- assert_eq!(configs.get(TableVersion).unwrap().to::<isize>(), 6);
Review Comment:
why this was removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support external config hudi-defaults.conf [hudi-rs]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on PR #117:
URL: https://github.com/apache/hudi-rs/pull/117#issuecomment-2339843703
@gohalo thanks for the PR. i've decided to refactor https://github.com/apache/hudi-rs/pull/118 instead which is easier to do. Can you pls update this PR to keep the test code refactoring change? then we can merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org