You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sentry.apache.org by "Mark Grover (JIRA)" <ji...@apache.org> on 2014/03/05 22:42:43 UTC
[jira] [Commented] (SENTRY-131) bin/sentry script doesn't find
config-tool.sh under some circumstances
[ https://issues.apache.org/jira/browse/SENTRY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921463#comment-13921463 ]
Mark Grover commented on SENTRY-131:
------------------------------------
Review at https://reviews.apache.org/r/18809/
> bin/sentry script doesn't find config-tool.sh under some circumstances
> ----------------------------------------------------------------------
>
> Key: SENTRY-131
> URL: https://issues.apache.org/jira/browse/SENTRY-131
> Project: Sentry
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Mark Grover
> Assignee: Mark Grover
> Fix For: 1.3.0
>
> Attachments: SENTRY-131.1.patch
>
>
> The sentry binary script makes an assumption that the config-tool.sh script is under SENTRY_HOME/bin/ which in turn assumes that the sentry jars are under SENTRY_HOME/lib.
> This is not a fair assumption in my opinion because the binary scripts and jars don't have to be under the same top level directory. I think a better way to do this would be to to have SENTRY_HOME/lib point to where the jars are, but don't assume that config-tool.sh is under SENTRY_HOME/bin. We can look for config-tool.sh in the same directory that the sentry script is present in, since they always are/should be.
--
This message was sent by Atlassian JIRA
(v6.2#6252)